1360210 - Crash in mozilla::a11y::FocusManager::IsFocused const

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P2)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-b4e96646-c81c-4cb5-87bd-025c22170330.
=============================================================


Seen while looking at nightly crash data - these Mac crashes appear to have started around 20170328095415 in Nightly 55: http://bit.ly/2pCSjoH. There appear to be a few crashes before that, but more in the 55 nightly cycle.


One report says: Using voiceover just to move around the UI, but the URL appears to no longer be on github: https://github.com/jimblandy/programming-in-rust-atlas/issues/223: https://crash-stats.mozilla.com/report/index/b4e96646-c81c-4cb5-87bd-025c22170330

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Not really enough bandwidth to jump on osx a11y issues (sadly) but if there is a quick fix we'll take it. Marco a nearby comment (in at the top of the stack) mentions bug 638465 and possibly this part of our code getting cleaned up if that one was fixed properly. Any recollection?

Comment 2

[Marco Zehe (:MarcoZ)]

Unfortunately not. That bug is quite old, and I no longer remember what the specifics were. Even re-reading it doesn't jerk a memory now.

Comment 3

[Trevor Saunders (:tbsaunde)]

if this is with e10s I suppose it could be an issue where aAccessible is null and some more mac stuff needs to proxy some methods it isn't yet.

Comment 4

[alexander :surkov (:asurkov)]

Not sure if crashes should go into the backlog at all, the crash is still visible through all releses including the nightly one, not high ratio though (https://crash-stats.mozilla.com/signature/?product=Firefox&signature=mozilla%3A%3Aa11y%3A%3AFocusManager%3A%3AIsFocused%20const&date=%3E%3D2017-09-04T14%3A34%3A00.000Z&date=%3C2017-09-11T14%3A34%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1#reports).

For a fix we could go with a null check and an assertion.

Comment 5

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 6

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/afedf4a55687576bf44b22549e90fcaeb2524a66
Bug 1360210 - crash in mozilla::a11y::FocusManager::IsFocused const, r=davidb

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/afedf4a55687

Comment 8

[Julien Cristau [:jcristau]]

Low volume so too late for 56 I guess.