Closed
Bug 1360220
Opened 7 years ago
Closed 7 years ago
Replace BytecodeEmitter::emitRequireObjectCoercible with JSOP_CHECKOBJCOERCIBLE
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
Details
Attachments
(1 file)
|
5.32 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
We now have a dedicated byte code for RequireObjectCoercible, so we no longer need to call the self-hosted method.
Attachment #8862502 -
Flags: review?(shu)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8862502 [details] [diff] [review] bug1360220.patch Review of attachment 8862502 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch.
Attachment #8862502 -
Flags: review?(shu) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b4c84a238f17a36f58421ac7d4bbdbef2279eff6
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ed8623eefe6c Replace emitRequireObjectCoercible with JSOP_CHECKOBJCOERCIBLE. r=shu
Keywords: checkin-needed
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ed8623eefe6c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Backed out for causing bug 1362590: https://hg.mozilla.org/mozilla-central/rev/37a5b7f6f101df2eb292b1b6baaf1540c9920e20
Pushed by gkwong@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/430f5feeec95 Backed out changeset ed8623eefe6c for causing fuzzblocker bug 1362590, rs=shu on IRC
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 9•7 years ago
|
||
Let's try to get this into the tree again, now that bug 1362590 is fixed. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a2f0b28bd97100195302a9d392fa7875e6900d8
Keywords: checkin-needed
|
||
Comment 10•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/714b7caf7e00 Replace emitRequireObjectCoercible with JSOP_CHECKOBJCOERCIBLE. r=shu
Keywords: checkin-needed
|
|
||
Comment 11•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/714b7caf7e00
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•