1360260 - aboutAddons.properties hardcodes Firefox

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Add-on Manager, enhancement, P5)

Description

[Mike Kaply [:mkaply]]

The phrase "Browser all Firefox Add-ons" is hardcoded in aboutAddons.properties:

http://searchfox.org/mozilla-central/source/mobile/android/locales/en-US/chrome/aboutAddons.properties

addons.browseAll=Browse all Firefox Add-ons

This should be using the brand substitutions (brand.properties or brand.dtd).

Or it should just say "Browser all Add-ons"

Comment 1

[friedger]

Attachment: Bug 1360260 - aboutAddons.properties hardcodes Firefox

Review commit: https://reviewboard.mozilla.org/r/141144/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141144/

Comment 2

[friedger]

Not sure who can review this.

I chose the second solution as the overhead of reading the brand file is not worth it IMHO.

Comment 3

[Mike Kaply [:mkaply]]

We should probably have UX review just for sanity.

Code looks good for me and I can checkin.

Thank you!

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Thanks for the NI! Could I get some context here?

Is it supposed to say "Browse"? or "Browser"?

I'm also going to NI Philip here since he's UX on Add-ons!

Comment 5

[Kev Needham [:kev]]

alam/ux - There's a string in the addons manager that states "browse all Firefox addons". Because we have different brands (e.g. Nightly, Aurora) and other builds that may not use official brands, we shouldn't use the Firefox brand in that string.

Desktop uses "Browse all add-ons", and agree that the patch above which uses that phrasing is preferable (to Product) to remove the reference to Firefox.

This is also likely a l10n bug, however, as it will have to be localized.

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 8869566 [details]
Bug 1360260 - aboutAddons.properties hardcodes Firefox

https://reviewboard.mozilla.org/r/141144/#review144730

::: mobile/android/locales/en-US/chrome/aboutAddons.properties:11
(Diff revision 1)
>  addonType.theme=Theme
>  addonType.locale=Locale
>  
>  addonStatus.uninstalled=%S will be uninstalled after restart.
>  
> -addons.browseAll=Browse all Firefox Add-ons
> +addons.browseAll=Browse all Add-ons

You need to change the entity name when changing the string so other locales pick up the change.

Comment 7

[friedger]

Comment on attachment 8869566 [details]
Bug 1360260 - aboutAddons.properties hardcodes Firefox

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141144/diff/1-2/

Comment 8

[friedger]

Entity name here is "addons.browseAll"? I tried to find some documentation how localization works at mozilla firefox.

Comment 9

[Dave Townsend [:mossop]]

(In reply to friedger from comment #8)
> Entity name here is "addons.browseAll"? I tried to find some documentation
> how localization works at mozilla firefox.

Yes that's right. You'll need to change that (addons.browserAllAddons for example) and change it in the calling code that retrieves the string.

Comment 10

[Mike Kaply [:mkaply]]

FYI, here's the documentation on this

https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

Comment 11

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.

Comment 12

[Shubham Kumar]

Hey, I wish to contribute. Is there something that i could work on here?

Comment 13

[Mike Kaply [:mkaply]]

Yes, although it's a little more complicated now:

https://searchfox.org/mozilla-central/source/mobile/android/chrome/content/aboutAddons.js#325

I'll try to get the right UX person to chime in here.

Comment 14

[Mike Kaply [:mkaply]]

I read this wrong. This is a Fennec bug and Fennec is going away. So this is a WONTFIX.

Shubham, let me know if you are looking for other bugs.

Comment 15

[Shubham Kumar]

Yes I'm looking for bugs in Firefox for Android. Please guide me.