1360262 - Annotate crash reports with a flag saying whether Debugger was used

Status: NEW

(Core :: JavaScript Engine, defect, P3)

Description

[Steve Fink [:sfink] [:s:]]

The Debugger code reimplements a number of interactions with the GC, which makes it a "bug rich environment". I was thinking it might be useful to annotate crash reports to say whether the Debugger was activated.

Comment 1

[Ted Campbell [:tcampbell]]

The CrashReporter::AnnotateCrashReport method should make this pretty straightforward to achieve. In js::Debugger::construct, we would notify some hook if this was the first time a debugger was created. Could do something simple like clear the hook the first time it is used as a way to notify only once.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: WIP: Bug 1360262 - Annotate crashdump if JS debugger ever ran

The JS Debugger has reasonably complex behaviour but only some users are
triggering it. Add an annotation to crash dumps if it has ever been used
during current process lifetime. Hopefully this lets us better identify
crashes that result from the debugger.

Comment 3

[Ted Campbell [:tcampbell]]

Here are the steps we need to follow: https://socorro.readthedocs.io/en/latest/annotations.html#adding-new-crash-annotations-to-a-crash-report