Update libevent to version 2.1.8-stable

RESOLVED FIXED in Firefox 55

Status

()

Core
IPC
RESOLVED FIXED
a year ago
10 months ago

People

(Reporter: RyanVM, Assigned: RyanVM)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
I've had a patch to update us to 2.1.8 ready for awhile and would like to go ahead and get it landed if there's no objections.

Regarding compatibility, I'm going to explicitly not touch ipc/chromium/src/base/message_pump_libevent.cc so that distros still shipping 2.0.x releases will continue to work. I'm a bit nervous about us coming to depend on 2.1.x features and silently breaking them, though. Happy to add a version check to configure and remove the 2.0.x compatibility code if people feel strongly about it.

The patch has bitrotted a bit, so I'll attach it after rebasing and running it through Try again.
(Assignee)

Updated

a year ago
status-firefox57: affected → ---
(Assignee)

Comment 2

a year ago
Comment on attachment 8862569 [details] [diff] [review]
update libevent to version 2.1.8-stable

Jan, can you please try this out and make sure it behaves nicely for you too? :)
Attachment #8862569 - Flags: feedback?(jbeich)

Comment 3

a year ago
Comment on attachment 8862569 [details] [diff] [review]
update libevent to version 2.1.8-stable

Looks OK, builds fine, e10s works fine. FreeBSD has been using system libevent-2.1.8 downstream for ~2.5 months without issues, and bundled <event2/event-config.h> seems to match what the package[0] has. Thank you.

[0] http://pkg.freebsd.org/FreeBSD:11:amd64/quarterly/All/libevent-2.1.8.txz

> +/* Define to 1 if you have the `accept4' function. */
> +#if !defined(__NetBSD__)
> +#define EVENT__HAVE_ACCEPT4 1
> +#endif

NetBSD 8.0 (in development) has accept4()[1] but it's too early to adjust the conditional. Downstream prefers system version[2] which uses detection via autoconf, anyway.

[1] https://github.com/jsonn/src/commit/7080a0aef7c0
[2] https://github.com/jsonn/pkgsrc/blob/ca489ddfd80d/www/firefox/mozilla-common.mk#L63

> +++ b/ipc/chromium/src/third_party/libevent/mac/event2/event-config.h
[...]
> +/* #define EVENT__HAVE_OPENSSL */

s/#define/#undef/ to match --disable-openssl as Gecko uses NSS. This may need to be documented in README.mozilla.
Attachment #8862569 - Flags: feedback?(jbeich) → feedback+
(Assignee)

Comment 4

a year ago
(In reply to Jan Beich from comment #3)
> s/#define/#undef/ to match --disable-openssl as Gecko uses NSS. This may
> need to be documented in README.mozilla.

Whoops, thanks for noticing. Fixed locally.
(In reply to Ryan VanderMeulen [:RyanVM] from comment #0)
> I've had a patch to update us to 2.1.8 ready for awhile and would like to go
> ahead and get it landed if there's no objections.
> 
> Regarding compatibility, I'm going to explicitly not touch
> ipc/chromium/src/base/message_pump_libevent.cc so that distros still
> shipping 2.0.x releases will continue to work. I'm a bit nervous about us
> coming to depend on 2.1.x features and silently breaking them, though. Happy
> to add a version check to configure and remove the 2.0.x compatibility code
> if people feel strongly about it.

Come to think of it, now that we have taskcluster, and considering the few resources it would consume, we could have a build job with a mozconfig that enables most --enable-system-* build options and a docker image with old versions of those dependencies.
Attachment #8862569 - Flags: review?(wmccloskey) → review+

Comment 6

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67f91dc6f365
Update libevent to 2.1.8-stable. r=billm

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/67f91dc6f365
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.