Closed
Bug 1360287
Opened 7 years ago
Closed 7 years ago
Lower sessionstore.js ss_observer eslint complexity
Categories
(Firefox for Android Graveyard :: General, enhancement)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: JanH, Assigned: JanH)
Details
Attachments
(1 file)
Within mobile (https://dxr.mozilla.org/mozilla-central/rev/0b77ed3f26c5335503bc16e85b8c067382e7bb1e/mobile/android/.eslintrc#53), the session store's observer service notification handler is now the complexity long pole. At the very least, the actual "browser:purge-session-..." logic can be split into a dedicated function, maybe other stuff as well...
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8866547 [details] Bug 1360287 - Factor out history/tabs data purging into separate function to reduce session store observer complexity. https://reviewboard.mozilla.org/r/138158/#review141356
Attachment #8866547 -
Flags: review?(s.kaspari) → review+
Pushed by mozilla@buttercookie.de: https://hg.mozilla.org/integration/autoland/rev/3cb58faa5ddf Factor out history/tabs data purging into separate function to reduce session store observer complexity. r=sebastian
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3cb58faa5ddf
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•