Lower sessionstore.js ss_observer eslint complexity

RESOLVED FIXED in Firefox 55

Status

()

Firefox for Android
General
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: JanH, Assigned: JanH)

Tracking

Trunk
Firefox 55
All
Android
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
Within mobile (https://dxr.mozilla.org/mozilla-central/rev/0b77ed3f26c5335503bc16e85b8c067382e7bb1e/mobile/android/.eslintrc#53), the session store's observer service notification handler is now the complexity long pole.

At the very least, the actual "browser:purge-session-..." logic can be split into a dedicated function, maybe other stuff as well...
Comment hidden (mozreview-request)

Comment 2

7 months ago
mozreview-review
Comment on attachment 8866547 [details]
Bug 1360287 - Factor out history/tabs data purging into separate function to reduce session store observer complexity.

https://reviewboard.mozilla.org/r/138158/#review141356
Attachment #8866547 - Flags: review?(s.kaspari) → review+

Comment 3

7 months ago
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/3cb58faa5ddf
Factor out history/tabs data purging into separate function to reduce session store observer complexity. r=sebastian
https://hg.mozilla.org/mozilla-central/rev/3cb58faa5ddf
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.