Add ability for users to hide github link from their public profile

RESOLVED FIXED

Status

developer.mozilla.org
User management
RESOLVED FIXED
a year ago
8 months ago

People

(Reporter: shobson, Unassigned)

Tracking

({in-triage, privacy})

Details

(Reporter)

Description

a year ago
Currently linking an MDN profile to a GitHub account (the only way we have for people to log in) displays that GitHub account on the user's profile.

We should add the ability to keep this information private.

I can think of good reasons why a user might want this including:
- personal safety
- disassociation between work and private profiles

But also, it doesn't really matter what their reasons are, we should respect wishes for privacy and the admins have access to this information separately for trouble shooting and spam management purposes.

Do our users want this? A user contact me in IRC today to ask me to delete their GitHub account from their profile. They are, of course, also not able to log in with GitHub anymore.
Keywords: in-triage, privacy
Summary: Add ability for use to remove github link from their public profile → Add ability for users to hide github link from their public profile

Comment 1

8 months ago
Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/b1efd3ea5457f58e7db6c2b2d4524414576e9559
Merge pull request #4484 from jwhitlock/hide-github-migration-1360294

bug 1360294: Add user.is_github_url_public

Comment 2

8 months ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/3874861c45964d651602dd391c846aeda78305cd
Bug 1360294 - Save is_github_url_public at registration

- Override allauth.account.adapter.DefaultAccountAdapter.save_user in kuma.users.adapaters.KumaAccountAdapter to add the is_github_url_public value
recovered from the registration form

https://github.com/mozilla/kuma/commit/7ecd4b8e195898320921111a711b96b76e30bb18
bug 1360294: Fix KumaAccountAdapter.save_user

* Call the parent DefaultAccountAdapter.save_user with commit=False
* Only save the user if commit=True
* Always return the created user, commited or uncommitted

https://github.com/mozilla/kuma/commit/085645009c99d43c5f8592117d108b7b1f9f421f
bug 1360294: Test is_github_url_public

* Can be set at account signup
* Can be set in profile editing
* Display of GitHub SocialAccount's URL is controlled by flag

https://github.com/mozilla/kuma/commit/371efb592b88dcaa46a16458119717ad00f6c0f1
Merge pull request #4346 from MatonAnthony/gh-url-public

Bug 1360294 - Add ability for users to hide github link from their public profile
Merged, deployed to production and staging
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.