Closed Bug 1360316 Opened 7 years ago Closed 7 years ago

Replace NewTabPrefsProvider in aboutNewTabService

Categories

(Firefox Graveyard :: Activity Streams: General, defect)

defect
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: ursula, Assigned: ursula)

References

Details

Attachments

(1 file)

Patch for Bug 1345122 breaks the ability to flip activity stream on because it gets rid of the initialization of the pref observer in NewTabPrefsProvider.jsm. Since this module is going away, I'll just move the pref observer right into aboutNewTabService.js
Attachment #8863381 - Flags: review?(edilee)
Comment on attachment 8863381 [details]
Bug 1360316 - Replace NewTabPrefsProvider in aboutNewTabService

https://reviewboard.mozilla.org/r/135130/#review138132

Looks like the remaining (incorrect) usage of NewTabPrefsProvider is NewTabWebChannel https://dxr.mozilla.org/mozilla-central/search?q=NewTabWebChannel which should be removed as part of Bug 1355166. Let's fix this issue now and leave the dead code removal for that other bug.
Attachment #8863381 - Flags: review?(edilee) → review+
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6cd42fe9c156
Replace NewTabPrefsProvider in aboutNewTabService r=Mardak
Blocks: 1355166
https://hg.mozilla.org/mozilla-central/rev/6cd42fe9c156
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: