1360414 - Position gradients using FindFirstTile

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: gradient-pos.patch

The origin of a tiled gradient needs to be positioned less than the origin of its clip bounds, otherwise it won't fill all of its clip bounds. There is an existing function used by the current code path that can be used to do this.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8862701 [details] [diff] [review]
gradient-pos.patch

Review of attachment 8862701 [details] [diff] [review]:
-----------------------------------------------------------------

This looks a lot like ethlin's patch in bug 1360112. Possibility of code reuse?

Comment 2

[Ryan Hunt [:rhunt] (on leave until early May)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #1)
> Comment on attachment 8862701 [details] [diff] [review]
> gradient-pos.patch
> 
> Review of attachment 8862701 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This looks a lot like ethlin's patch in bug 1360112. Possibility of code
> reuse?

Hm, yeah it does look like we're calculating similar things, in different places. I don't have a strong opinion, this was just using a function local to nsCSSRenderingGradients.cpp used in the other code path.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Ok. I don't have a strong opinion either, this is fine for now.

Comment 4

[Ryan Hunt [:rhunt] (on leave until early May)]

I'd be interested in seeing if we can unify some of the calculations we have to do. Maybe when the dust settles a bit more.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/9bfbae06d8e2
Position webrender gradient bounds using FindFirstTile r=jrmuizel

Comment 6

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/9bfbae06d8e2