1360423 - Remove the ability to send synchronous notifications from MediaEventSource

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

It turns out that sync notification is a bad idea which is easy to be misused and could results in unexpected reentrant  call flow.

Since it has no users after the mass media code refactoring, it is a good time to remove it now to prevent future users.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1360423 - backout P5 and P2 from bug 1281090.

It turns out that sync notification is a bad idea which is easy
to be misused and could results in unexpected reentrant call flow.
Since it has no users after the mass media code refactoring, it is
good to remove it now to prevent future users.

Backed out changeset fb5b05298007
Backed out changeset 9e1fb308cf51

Review commit: https://reviewboard.mozilla.org/r/135028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135028/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8863233 [details]
Bug 1360423 - backout P5 and P2 from bug 1281090.

https://reviewboard.mozilla.org/r/135028/#review137952

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf048c7572d7
backout P5 and P2 from bug 1281090. r=gerald

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Merged backout
https://hg.mozilla.org/mozilla-central/rev/cf048c7572d7