Closed
Bug 1360423
Opened 7 years ago
Closed 7 years ago
Remove the ability to send synchronous notifications from MediaEventSource
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(1 file)
It turns out that sync notification is a bad idea which is easy to be misused and could results in unexpected reentrant call flow. Since it has no users after the mass media code refactoring, it is a good time to remove it now to prevent future users.
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8863233 -
Flags: review?(gsquelart)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8863233 [details] Bug 1360423 - backout P5 and P2 from bug 1281090. https://reviewboard.mozilla.org/r/135028/#review137952
Attachment #8863233 -
Flags: review?(gsquelart) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Thanks!
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cf048c7572d7 backout P5 and P2 from bug 1281090. r=gerald
Comment 5•7 years ago
|
||
backout bugherder |
Merged backout https://hg.mozilla.org/mozilla-central/rev/cf048c7572d7
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•