Closed Bug 1360424 Opened 7 years ago Closed 7 years ago

stylo: some first-letter tests started failing after pseudo probing changes

Categories

(Core :: CSS Parsing and Computation, defect, P3)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: heycam, Unassigned)

References

(Blocks 1 open bug)

Details

After https://github.com/servo/servo/pull/16637 merged, the following tests started asserting and failing.  For now I've marked them as expected fail.

https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=2454031a48366e6d36349d19c996d42932013565&selectedJob=95025893

REFTEST TEST-UNEXPECTED-FAIL | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/first-letter/dynamic-3a.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/first-letter/dynamic-3a.html | image comparison, max difference: 255, number of differing pixels: 72
REFTEST TEST-UNEXPECTED-FAIL | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/first-letter/dynamic-3a.html | assertion count 6 is more than expected 0 assertions
REFTEST TEST-UNEXPECTED-FAIL | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/first-letter/dynamic-3b.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/first-letter/dynamic-3b.html | image comparison, max difference: 255, number of differing pixels: 72
REFTEST TEST-UNEXPECTED-FAIL | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/first-letter/dynamic-3b.html | assertion count 6 is more than expected 0 assertions
REFTEST TEST-UNEXPECTED-FAIL | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/first-letter/379799-1.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/first-letter/379799-1.html | image comparison, max difference: 255, number of differing pixels: 133
REFTEST TEST-UNEXPECTED-FAIL | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/first-letter/379799-1.html | assertion count 6 is more than expected 0 assertions
Should revisit once bug 1324618 is fixed.
Depends on: 1324618
Priority: -- → P3
Looks to me like this got fixed by bug 1369187.
Status: NEW → RESOLVED
Closed: 7 years ago
Depends on: 1369187
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.