Closed Bug 1360454 Opened 2 years ago Closed 2 years ago

IPCBlobInputStream can take the original stream directly if created on the parent process

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file)

IDB and other APIs use PBackground child actors also on the parent processes (in non-e10s mode).
In this case we need to avoid the cloning of nsFileInputStream when created from the deserialization and we can retrieve the remote nsIInputStream directly from IPCBlobInputStreamStorage.
Assignee: nobody → amarchesini
Attachment #8862737 - Flags: review?(bugs)
Blocks: 1353629
Comment on attachment 8862737 [details] [diff] [review]
blob_parent.patch

> bool
> nsFileInputStream::IsCloneable() const
> {
>-    return XRE_IsParentProcess();
>+    return XRE_IsParentProcess() && mFile;
> }
This needs a good comment. Why && mFile is needed here.
Attachment #8862737 - Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6be0d0f4aae5
IPCBlobInputStream can take the original stream directly if created on the parent process, r=smaug
https://hg.mozilla.org/mozilla-central/rev/6be0d0f4aae5
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.