1360458 - Status bar no longer has top border

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Tim Nguyen :ntim]

Bug 1349173 changed the status bar class from devtools-toolbar-bottom to devtools-status-bottom

Comment 1

[Sharath Narayan]

I am have been poking around the code for a while and would like to jump in. Can I work on this issue?

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Sharath Narayan from comment #1)
> I am have been poking around the code for a while and would like to jump in.
> Can I work on this issue?
Excellent, assigned to you!

Here is the StatusBar component with the new `devtools-status-bottom` CSS class.
http://searchfox.org/mozilla-central/rev/3dc6ceb42746ab40f1441e1e659ffb8f62ae78e3/devtools/client/netmonitor/src/components/status-bar.js#43

The previous `devtools-toolbar-bottom` CSS class is here:
http://searchfox.org/mozilla-central/rev/3dc6ceb42746ab40f1441e1e659ffb8f62ae78e3/devtools/client/themes/toolbars.css#77

I don't see the `devtools-toolbar-bottom` used anywhere, so it looks safe to just rename it to `devtools-status-bottom`


Honza

Comment 3

[Tim Nguyen :ntim]

I would prefer we do this the opposite way round:

Rename devtools-status-bottom to devtools-toolbar-bottom in status-bar.js since this class is aimed to be generic.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Tim Nguyen :ntim from comment #3)
> I would prefer we do this the opposite way round:
> 
> Rename devtools-status-bottom to devtools-toolbar-bottom in status-bar.js
> since this class is aimed to be generic.
ok, works for me.

Honza

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1360458 - Fix status-bar top border;

Review commit: https://reviewboard.mozilla.org/r/141886/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141886/

Comment 6

[[e-mail]]

Comment on attachment 8870445 [details]
Bug 1360458 - Fix status-bar top border;

https://reviewboard.mozilla.org/r/141886/#review146308

`devtools-status-bottom` class seems not exist now, nice catch!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bc06830ba0b
Fix status-bar top border; r=gasolin

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2bc06830ba0b

Comment 9

[Johann Hofmann [:johannh]]

Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=f7adbf457ee20eeffde72694e0d17d73616e3cfd&newProject=mozilla-central&newRev=bdf2d1918fb0b434ab8782d003afbe3f9639cd45&filter=netmonitor

Comment 10

[Md. Majedul islam]

I have reproduce this bug with Nightly 55.0a1 (2017-04-28)  on Ubuntu 16.04 (64 Bit).

This bug's fix is verified on Latest Beta 55.0b5 .

Build ID :   20170626235638
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

Comment 11

[Md. Rahimul Islam]

I have successfully reproduced this bug with Nightly 55.0a1 (2017-04-28) (32-bit)  on windows 10(32bit)

this bug is verified fix with  latest beta 55.0b5 (32-bit)

Build ID: 20170626165718
Mozilla/5.0 (Windows NT 10.0; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170628]

Comment 12

[Md. Majedul islam]

As per Comment 10 and Comment 11, I am marking this bug as verified fixed.