Closed
Bug 1360463
Opened 7 years ago
Closed 7 years ago
Item under column heading have been slightly moved to right
Categories
(Thunderbird :: Folder and Message Lists, defect)
Tracking
(thunderbird_esr5254+ fixed, thunderbird53 wontfix, thunderbird54 fixed, thunderbird55 fixed)
RESOLVED
FIXED
Thunderbird 55.0
People
(Reporter: ovari123, Assigned: Paenglab)
References
Details
Attachments
(4 files)
1.25 KB,
patch
|
aceman
:
review+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr52+
|
Details | Diff | Splinter Review |
762 bytes,
patch
|
alta88
:
review+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr52+
|
Details | Diff | Splinter Review |
6.30 KB,
image/png
|
Details | |
101.35 KB,
image/png
|
Details |
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0 Build ID: 20170421105455 Steps to reproduce: Items under column heading all moved slightly to the right. This seems appropriate when an image is placed there, like in the Subject column there can be Reply/Forward/Redirect image. Does not seem correct to have the items moved slightly to the right under column headings: Received, Date, Status. Thank you Linux Mint 18.1 Cinnamon 64-bit Thunderbird 53.0b2 (64-bit)
Comment 2•7 years ago
|
||
I think this move should not apply to checkboxes cells
Assignee | ||
Comment 3•7 years ago
|
||
This is a regression of bug 1354263. Unfortunately folderPane.css affects also the threadPane.
Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8863144 -
Flags: review?(acelists)
Comment on attachment 8863144 [details] [diff] [review] Bug1360463.patch Review of attachment 8863144 [details] [diff] [review]: ----------------------------------------------------------------- Thanks.
Attachment #8863144 -
Flags: review?(acelists) → review+
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 5•7 years ago
|
||
https://hg.mozilla.org/comm-central/rev/3629bdd18f2e534f2d2f3b3fe29d945e2a230abe
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8863144 [details] [diff] [review] Bug1360463.patch [Approval Request Comment] Regression caused by (bug #): 1354263 User impact if declined: too much whitespace before the text in the threadPane Testing completed (on c-c, etc.): on c-c Risk to taking this patch (and alternatives if risky): low
Attachment #8863144 -
Flags: approval-comm-esr52?
Attachment #8863144 -
Flags: approval-comm-beta?
Updated•7 years ago
|
Attachment #8863144 -
Flags: approval-comm-beta? → approval-comm-beta+
Comment on attachment 8863253 [details] [diff] [review] subscriptions.patch Wouldn't it be better to not have linux diverge from win/osx unnecessarily (in either folderPane.css or feed-subscriptions.css? I realize the regressing bug was done for GTK, but perhaps there's a way to make them all the same. Just a suggestion, the patch does fix the immediate problem..
Attachment #8863253 -
Flags: review?(alta88) → review+
Assignee | ||
Comment 10•7 years ago
|
||
Follow-up fix: https://hg.mozilla.org/comm-central/rev/3434edf79017dfc8c274d67c6d5f6899c305198e
Assignee | ||
Comment 11•7 years ago
|
||
Comment on attachment 8863253 [details] [diff] [review] subscriptions.patch [Approval Request Comment] Additional patch to fix the icons in subscription dialog
Attachment #8863253 -
Flags: approval-comm-esr52?
Attachment #8863253 -
Flags: approval-comm-beta?
Reporter | ||
Comment 12•7 years ago
|
||
Does the patch also fix the selected option shown in the “Folder Pane Toolbar” on Linux Mint?
Assignee | ||
Comment 13•7 years ago
|
||
Sorry, I don't understand what you mean.
Reporter | ||
Comment 14•7 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #13) > Sorry, I don't understand what you mean. Menu Bar → View → Toolbars → Folder Pane Toolbar (enabled) Attached image shows the “Folder Pane Toolbar” with “All Folders” selected; however, it is also been slightly moved to the right on Linux. On Windows it is shown correctly.
Assignee | ||
Comment 15•7 years ago
|
||
Ovari123, please can you file a bug, it's not fixed.
Reporter | ||
Comment 16•7 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #15) > Ovari123, please can you file a bug, it's not fixed. Bug 1361157
Updated•7 years ago
|
Component: Untriaged → Folder and Message Lists
Updated•7 years ago
|
Attachment #8863253 -
Flags: approval-comm-beta? → approval-comm-beta+
Comment 17•7 years ago
|
||
Beta (TB 54): https://hg.mozilla.org/releases/comm-beta/rev/7d190641fd271582363628b0244aef0070c5e73b https://hg.mozilla.org/releases/comm-beta/rev/6432e0a6d03e601a2501094fd45d9b2dfeaf5503
status-thunderbird53:
--- → wontfix
status-thunderbird54:
--- → fixed
status-thunderbird55:
--- → fixed
status-thunderbird_esr52:
--- → affected
tracking-thunderbird_esr52:
--- → +
Updated•7 years ago
|
Attachment #8863144 -
Flags: approval-comm-esr52? → approval-comm-esr52+
Updated•7 years ago
|
Attachment #8863253 -
Flags: approval-comm-esr52? → approval-comm-esr52+
Comment 19•7 years ago
|
||
Hopefully constructive for all who don’t want to wait until version Thunderbird 55. You can fix this issue temporarily by adding a CSS rule to the userChrome.css file: /* Spacing fix until Thunderbird 55 */ treechildren::-moz-tree-image { width: inherit !important; height: inherit !important; } For clarification I’ve attached a screenshot what spacing we are talking about (unwanted spacing in purple).
Comment 20•7 years ago
|
||
TB 52 ESR: https://hg.mozilla.org/releases/comm-esr52/rev/3808f7c1c4da https://hg.mozilla.org/releases/comm-esr52/rev/d0d7838e2332
Updated•7 years ago
|
tracking-thunderbird_esr52:
--- → 54+
You need to log in
before you can comment on or make changes to this bug.
Description
•