Closed Bug 1360559 Opened 7 years ago Closed 7 years ago

layout/forms/test/test_bug348236.html | Select's value should be 3 after hovering over option 3 and pressing ALT-Up. got "2", expected "3"

Categories

(Core :: Layout: Form Controls, defect)

Product:
Core
Component:
Layout: Form Controls
Platform:
Unspecified
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: kshriram18, Assigned: sparky)

References

Details

Attachments

(1 file)

Bug 1360559 - Adjust mouse position in test_bug348236.html.
59 bytes, text/x-review-board-request
jmaher
: review+
Details
Blocks: 1319782
No longer blocks: 1290183
Flags: needinfo?(bugs)
here is data from the log mentioned in comment 0:
task 2017-04-28T09:35:32.556986Z] 09:35:32     INFO - TEST-START | editor/libeditor/tests/test_dragdrop.html
[task 2017-04-28T09:35:33.120378Z] 09:35:33     INFO - GECKO(1324) | ++DOMWINDOW == 76 (0x7fac42c49800) [pid = 1324] [serial = 434] [outer = 0x7fac4afa4800]
[task 2017-04-28T09:35:33.289930Z] 09:35:33     INFO - GECKO(1324) | [1324] WARNING: Unable to find interface object on global: file /home/worker/workspace/build/src/dom/base/nsDOMClassInfo.cpp, line 1855
[task 2017-04-28T09:35:33.601074Z] 09:35:33     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Test dragging regular text 
[task 2017-04-28T09:35:33.601622Z] 09:35:33     INFO - input.selectionStart
[task 2017-04-28T09:35:33.608264Z] 09:35:33     INFO - 1
[task 2017-04-28T09:35:33.614203Z] 09:35:33     INFO - input.selectionEnd
[task 2017-04-28T09:35:33.618492Z] 09:35:33     INFO - 4
[task 2017-04-28T09:35:33.679130Z] 09:35:33     INFO - TEST-INFO | started process screentopng
[task 2017-04-28T09:35:37.217432Z] 09:35:37     INFO - TEST-INFO | screentopng: exit 0
[task 2017-04-28T09:35:37.221223Z] 09:35:37     INFO - Buffered messages logged at 09:35:33
[task 2017-04-28T09:35:37.225417Z] 09:35:37     INFO - must wait for load
[task 2017-04-28T09:35:37.231506Z] 09:35:37     INFO - Buffered messages finished
[task 2017-04-28T09:35:37.237344Z] 09:35:37     INFO - TEST-UNEXPECTED-FAIL | editor/libeditor/tests/test_dragdrop.html | Test dragging input - got "trapDrag was not called", expected null
[task 2017-04-28T09:35:37.243893Z] 09:35:37     INFO -     SimpleTest.is@SimpleTest/SimpleTest.js:310:5
[task 2017-04-28T09:35:37.246414Z] 09:35:37     INFO -     doTest@editor/libeditor/tests/test_dragdrop.html:56:3
[task 2017-04-28T09:35:37.248719Z] 09:35:37     INFO -     focusedOrLoaded/<@SimpleTest/SimpleTest.js:791:59
[task 2017-04-28T09:35:37.251716Z] 09:35:37     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Test dragging textarea 
[task 2017-04-28T09:35:37.255942Z] 09:35:37     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Test dragging contenteditable 
[task 2017-04-28T09:35:37.263155Z] 09:35:37     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Drag text/html onto input 
[task 2017-04-28T09:35:37.265876Z] 09:35:37     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Drag text/html onto disabled input 
[task 2017-04-28T09:35:37.268113Z] 09:35:37     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Drag text/html onto readonly input 
[task 2017-04-28T09:35:37.270553Z] 09:35:37     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Drag text/html onto input 
[task 2017-04-28T09:35:37.277518Z] 09:35:37     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Drag text/html and text/plain onto input 
[task 2017-04-28T09:35:37.282166Z] 09:35:37     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Drag text/x-moz-text-internal onto input 
[task 2017-04-28T09:35:37.285317Z] 09:35:37     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Drag text/plain onto contenteditable child nodes 
[task 2017-04-28T09:35:37.291829Z] 09:35:37     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Drag text/plain onto contenteditable text 
[task 2017-04-28T09:35:37.297204Z] 09:35:37     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Drag text/html onto contenteditable child nodes 
[task 2017-04-28T09:35:37.300591Z] 09:35:37     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Drag text/html onto contenteditable italic 
[task 2017-04-28T09:35:37.304779Z] 09:35:37     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Drag text/html onto contenteditable italic text 
[task 2017-04-28T09:35:37.315380Z] 09:35:37     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Move text/html and text/plain from contenteditable onto input 
[task 2017-04-28T09:35:37.318227Z] 09:35:37     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Move text/html and text/plain from contenteditable onto itself child nodes 
[task 2017-04-28T09:35:37.320346Z] 09:35:37     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Move text/html and text/plain from contenteditable onto itself italic 
[task 2017-04-28T09:35:37.327797Z] 09:35:37     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Move text/html and text/plain from contenteditable onto itself text 
[task 2017-04-28T09:35:37.332181Z] 09:35:37     INFO - GECKO(1324) | [1324] WARNING: NS_ENSURE_TRUE(root) failed: file /home/worker/workspace/build/src/editor/libeditor/EditorBase.cpp, line 3477
[task 2017-04-28T09:35:37.334730Z] 09:35:37     INFO - GECKO(1324) | [1324] WARNING: NS_ENSURE_TRUE(root) failed: file /home/worker/workspace/build/src/editor/libeditor/EditorBase.cpp, line 3477
[task 2017-04-28T09:35:37.337048Z] 09:35:37     INFO - GECKO(1324) | [1324] WARNING: NS_ENSURE_TRUE(root) failed: file /home/worker/workspace/build/src/editor/libeditor/EditorBase.cpp, line 3477
[task 2017-04-28T09:35:37.341327Z] 09:35:37     INFO - GECKO(1324) | [1324] WARNING: NS_ENSURE_TRUE(root) failed: file /home/worker/workspace/build/src/editor/libeditor/EditorBase.cpp, line 3477
[task 2017-04-28T09:35:37.344048Z] 09:35:37     INFO - GECKO(1324) | [1324] WARNING: NS_ENSURE_TRUE(root) failed: file /home/worker/workspace/build/src/editor/libeditor/EditorBase.cpp, line 3477
[task 2017-04-28T09:35:37.347088Z] 09:35:37     INFO - GECKO(1324) | [1324] WARNING: NS_ENSURE_TRUE(root) failed: file /home/worker/workspace/build/src/editor/libeditor/EditorBase.cpp, line 3477
[task 2017-04-28T09:35:37.353014Z] 09:35:37     INFO - GECKO(1324) | [1324] WARNING: NS_ENSURE_TRUE(root) failed: file /home/worker/workspace/build/src/editor/libeditor/EditorBase.cpp, line 3477
[task 2017-04-28T09:35:37.355870Z] 09:35:37     INFO - GECKO(1324) | [1324] WARNING: NS_ENSURE_TRUE(root) failed: file /home/worker/workspace/build/src/editor/libeditor/EditorBase.cpp, line 3477
[task 2017-04-28T09:35:37.360665Z] 09:35:37     INFO - GECKO(1324) | [1324] WARNING: NS_ENSURE_TRUE(root) failed: file /home/worker/workspace/build/src/editor/libeditor/EditorBase.cpp, line 3477
[task 2017-04-28T09:35:37.363327Z] 09:35:37     INFO - GECKO(1324) | [1324] WARNING: NS_ENSURE_TRUE(target) failed: file /home/worker/workspace/build/src/editor/libeditor/EditorBase.cpp, line 1925
[task 2017-04-28T09:35:37.370077Z] 09:35:37     INFO - GECKO(1324) | [1324] WARNING: 'selection.mReply.mContentsRoot != mRootContent', file /home/worker/workspace/build/src/dom/events/IMEContentObserver.cpp, line 1338
[task 2017-04-28T09:35:37.373093Z] 09:35:37     INFO - GECKO(1324) | [1324] WARNING: '!mIMEContentObserver->UpdateSelectionCache()', file /home/worker/workspace/build/src/dom/events/IMEContentObserver.cpp, line 1773
[task 2017-04-28T09:35:37.375270Z] 09:35:37     INFO - TEST-PASS | editor/libeditor/tests/test_dragdrop.html | Drag non-editable text/html onto contenteditable text 
[task 2017-04-28T09:35:37.377431Z] 09:35:37     INFO - GECKO(1324) | MEMORY STAT | vsize 2134MB | residentFast 301MB | heapAllocated 120MB
[task 2017-04-28T09:35:37.379486Z] 09:35:37     INFO - TEST-OK | editor/libeditor/tests/test_dragdrop.html | took 3239ms


that failure seems to be here in the test case:
https://dxr.mozilla.org/mozilla-central/source/editor/libeditor/tests/test_dragdrop.html?q=path%3Atest_dragdrop.html&redirect_type=single#52

what is interesting is this fails for a type <input> and nothing else, possibly 16.04 has a different theme for <input> elements?

:jet, who could help us figure this out?
sorry, my comments were related to test_dragdrop.html, not test_bug348236.html  what the summary was filed as :(
my comment for test_dragdrop.html is already tracked in bug 1335880
This test and the one for bug 1335880 synthesize user gestures at specific pixel offsets. Can we overlay screenshots from ubuntu 12 & 16.04? I suspect the content shifted under us (due to font and/or theme variation) and the synthesized mouse moves expect the old offsets.
Flags: needinfo?(bugs)
oh, good point we can figure that out!
I forced a ok() statement to be false and got a screenshot for a 12.04 image.


16.04:
https://public-artifacts.taskcluster.net/IoPAnGFqSEiN975AtKCrOg/0/public/test_info//mozilla-test-fail-screenshot_oWf57p.png

12.04:
https://public-artifacts.taskcluster.net/FDpVOzAISMKiXfCdMUDLCQ/0/public/test_info//mozilla-test-fail-screenshot_E8oilZ.png

there are many differences in the screenshots, I also think I didn't get them at the same spot.
Here's a patch for this bug: https://hg.mozilla.org/try/rev/e07842093f48bc01eadfa1dad050af93323b26ae

The failures seen in that push are all intermittent. It's based on the solution for bug 1335880 which adjusts the y position of the mouse by moving it down 2 pixels. Shall I submit this patch for review? (Minus the .yml changes).
Comment on attachment 8870506 [details]
Bug 1360559 - Adjust mouse position in test_bug348236.html.

https://reviewboard.mozilla.org/r/141934/#review145632

on the condition there is a try push showing |try -b do -p all -u mochitests -t none|
Attachment #8870506 - Flags: review?(jmaher) → review+
Assignee: nobody → gmierz2
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b7bf0df3681
Adjust mouse position in test_bug348236.html. r=jmaher
Not sure what's changed but a very similar same patch (with no significant changes) is working today: https://treeherder.mozilla.org/#/jobs?repo=try&revision=844e6d4f1cf65464cdd672a2b1533ff3cfdbb840

These additional changes don't do anything to fix the tests though, here's a test which uses them and still fails: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5587978b41faa7e451d5b06fb67b1c7b5ca42a9f

Joel, do you think we could try landing this patch again?
Flags: needinfo?(jmaher)
can you push to try with the original patch?  the try pushes you have are forcing PGO, I want to see if the original patch works good on try with 10 retriggers.
Flags: needinfo?(jmaher)
I think the trychooser is slightly out of date or I may have misunderstood because it seems like it said to add that line to get linux64-pgo to run. But apparently I didn't need it since it was scheduled without it in this try run. Either way, here's the push with the retriggers: https://treeherder.mozilla.org/#/jobs?repo=try&revision=63a8d8ed2eb19a8c351cbff51388d48ea97bb8ae

The PGO tests are still running at the moment but the linux64 tests seem promising.
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/648eadae5964
Adjust mouse position in test_bug348236.html. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/648eadae5964
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: