Update builder NDK to include AArch64/ARM64 platform and 'source.properties' file

RESOLVED FIXED

Status

Release Engineering
Platform Support
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

(Blocks: 1 bug)

unspecified
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
We need an updated NDK r11b package that includes:

* AArch64/ARM64 platform files (e.g. "platforms/android-21/arch-arm64") to support building Fennec for AArch64.

* 'source.properties' file at the NDK root to satisfy bug 1360291.
(Assignee)

Updated

a year ago
Assignee: nobody → nchen
Status: NEW → ASSIGNED
(Assignee)

Updated

a year ago
Depends on: 1361757
(Assignee)

Comment 1

a year ago
Created attachment 8864623 [details] [diff] [review]
Update NDK on builders to include AArch64/ARM64 support (v1)

Use a new version of the packaged NDK that includes AArch64/ARM64
support and includes the 'source.properties' file, so we can detect the
NDK version.
Attachment #8864623 - Flags: review?(nalexander)
Comment on attachment 8864623 [details] [diff] [review]
Update NDK on builders to include AArch64/ARM64 support (v1)

Review of attachment 8864623 [details] [diff] [review]:
-----------------------------------------------------------------

This and the ticket that uses `source.properties` are split, but are you certain that user-installed NDKs (including those installed by |mach bootstrap|) always include `source.properties`?  If not, we need to ensure that we fall back correctly.  (I vaguely remember that our NDK packages on the builders have files removed, so maybe `source.properties` was something we got rid of and you're just re-instating it.)

Marking r+ so you don't need a re-review cycle in the affirmative case.
Attachment #8864623 - Flags: review?(nalexander) → review+
(Assignee)

Comment 3

a year ago
Right, `source.properties` is part of the standard NDK package, but we stripped it out from our builders' NDK package.

Comment 4

a year ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bdfc2fa3ca8b
Update NDK on builders to include AArch64/ARM64 support; r=nalexander

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bdfc2fa3ca8b
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.