Closed Bug 1360631 Opened 7 years ago Closed 7 years ago

VS 2015 x86 compile fails when using start-shell.bat [mspdb140.dll is missing]

Categories

(Firefox Build System :: General, defect)

Unspecified
Windows
defect
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: frg, Assigned: frg)

References

Details

Attachments

(2 files)

Attached image ClipboardVS2015.png
+++ This bug was initially created as a clone of Bug #1318143 +++

The VS2015 x86 cross compiler has the same dependencies as the VS2017 x86 cross compiler. To be able to compile using only start-shell.bat it needs the path for the x64 compiler appended. Currently it only works using start-shell-msvc2015.bat. With only start-shell.bat a missing mspdb140.dll is reported and the build fails.
Looks like a copycat from the VS2017 part is all what is needed. 

I have not set mozreview yet and didn't try it on try yet so if someone wants to drive it thru under his name be my guest :)
Comment on attachment 8863218 [details] [diff] [review]
1360631-vs2015-x86-vswhere.patch

This looks pretty sensible. Thanks for the patch!
Attachment #8863218 - Flags: review+
Assignee: nobody → frgrahl
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d338de5e37ec
Fix VS2015 x86 cross compiling using start-shell.bat. r=ted
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d338de5e37ec
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: