If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Merge how tecken/symbolicate and tecken/download downloads symbols

RESOLVED FIXED

Status

Socorro
Symbols
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: peterbe, Assigned: peterbe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

PR
41 bytes, text/x-github-pull-request
Details | Review | Splinter Review
(Assignee)

Description

6 months ago
Both tecken/symbolicate/views.py and tecken/download/views.py share that it's using settings.SYMBOL_URLS. However, the code that does the actual download is different (at the time of writing). 

They do slightly different things so some refactoring is necessary. The symbolidate/views.py code actually downloads the bytes. The download/views.py only cares if the object exists or generate a presigned URL.
(Assignee)

Updated

6 months ago
Assignee: nobody → peterbe
(Assignee)

Comment 1

6 months ago
Created attachment 8863709 [details] [review]
PR

Comment 2

6 months ago
Commit pushed to master at https://github.com/mozilla/tecken

https://github.com/mozilla/tecken/commit/51b8ac0a4db1ae1c949b3f6f548c28b472ce0783
fixes bug 1360633, 1360637 - Support public and non-public S3 buckets (#61)

Updated

6 months ago
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.