Closed
Bug 1360637
Opened 9 years ago
Closed 9 years ago
Merge how tecken/symbolicate and tecken/download downloads symbols
Categories
(Socorro :: Symbols, task)
Socorro
Symbols
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: peterbe, Assigned: peterbe)
References
Details
Attachments
(1 file)
Both tecken/symbolicate/views.py and tecken/download/views.py share that it's using settings.SYMBOL_URLS. However, the code that does the actual download is different (at the time of writing).
They do slightly different things so some refactoring is necessary. The symbolidate/views.py code actually downloads the bytes. The download/views.py only cares if the object exists or generate a presigned URL.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → peterbe
|
|
Assignee | |
Comment 1•9 years ago
|
||
|
||
Comment 2•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/tecken
https://github.com/mozilla/tecken/commit/51b8ac0a4db1ae1c949b3f6f548c28b472ce0783
fixes bug 1360633, 1360637 - Support public and non-public S3 buckets (#61)
|
|
||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•