Closed Bug 1360662 Opened 7 years ago Closed 7 years ago

Only expose a property as a context property if it is listed in '-moz-context-properties'

Categories

(Core :: SVG, enhancement)

Product:
Core
Component:
SVG
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(2 files)

part 1 - Only expose properties that are listed in '-moz-context-properties' as image context properties
2.02 KB, patch
dholbert
: review+
Details | Diff | Splinter Review
part 2 - Test that only properties listed in '-moz-context-properties' are exposed as image context properties
4.61 KB, patch
dholbert
: review+
Details | Diff | Splinter Review 
In bug 1350010 I didn't fix the behavior of context properties to only expose them if they are listed in '-moz-context-properties'. That needs to be fixed.
Comment on attachment 8863017 [details] [diff] [review]
part 1 - Only expose properties that are listed in '-moz-context-properties' as image context properties

Review of attachment 8863017 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8863017 - Flags: review?(dholbert) → review+
Comment on attachment 8863018 [details] [diff] [review]
part 2 - Test that only properties listed in '-moz-context-properties' are exposed as image context properties

Review of attachment 8863018 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with a few nits (which apply to both of the testcases here)

::: layout/reftests/svg/as-image/context-fill-08.html
@@ +1,4 @@
> +<!DOCTYPE html>
> +<html>
> +  <head>
> +    <title>Test context-fill only |-moz-context-properties: stroke| is specified</title>

This doesn't quite make grammatical sense.

 - s/only/when only/
 - and maybe use quotes instead of vertical bars (because "|-moz" looks a bit like some weird new type of vendor-prefixing.)

@@ +7,5 @@
> +img {
> +  width: 100px;
> +  height: 100px;
> +  -moz-context-properties: stroke;
> +  fill: red;

Maybe add "stroke: red" here, too, for good measure?  (This proves that we don't e.g. accidentally interpret "-moz-context-properties: stroke" as applying any specified stroke for all context-* properties.)
Attachment #8863018 - Flags: review?(dholbert) → review+
(In reply to Daniel Holbert [:dholbert] (AFK May 3-7, 13-21) from comment #4)
>  - and maybe use quotes instead of vertical bars (because "|-moz" looks a
> bit like some weird new type of vendor-prefixing.)

Specifically, |-moz reminds me of the *|*::-moz syntax used in some of our UA css files, e.g. here:
https://dxr.mozilla.org/mozilla-central/rev/5278e2a35fc8f2be390243db1e62858bf0982055/layout/style/res/forms.css#13
...which is partly why my first visual parsing stumbled a bit and didn't think to interpret the vertical-bar as a form of quotes.
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/657e214ca528
part 1 - Only expose properties that are listed in '-moz-context-properties' as image context properties. r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/13b354344cf7
part 2 - Test that only properties listed in '-moz-context-properties' are exposed as image context properties. r=dholbert
https://hg.mozilla.org/mozilla-central/rev/657e214ca528
https://hg.mozilla.org/mozilla-central/rev/13b354344cf7
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: