Entire log for AWSY run highlighted

RESOLVED FIXED

Status

Tree Management
Treeherder: Log Viewer
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: erahm, Assigned: KWierso)

Tracking

Details

Attachments

(1 attachment)

For some reason the log viewer is insisting on highlighting the entire log for an awsy run [1]. 


[1] https://treeherder.mozilla.org/logviewer.html#?job_id=94956322&repo=mozilla-central&lineNumber=1-3003
camd, wlach suggested you could help out here.
Flags: needinfo?(cdawson)
(Assignee)

Comment 2

7 months ago
The failure summary pane for the awsy jobs things there's "Unsuccessful Execution Steps: Unnamed step : unknown." which seems off, since the jobs are reported as successes and I don't see any non-zero return codes in the logs.

The Windows awsy jobs show the same "Unsuccessful" steps, but they also include a line flagged as an error:  AttributeError: 'module' object has no attribute 'exc_value' 
So when you open those logs, it only highlights that one line.
Yeah, so this is happening because we will highlight the first step that is not ``result === success``.  In this case, the steps are showing as:

{
    id: 361494755
    errors: []
    result: "unknown"
    name	: "Unnamed step"
    started: null
    finished: null
    started_line_number: 0
    finished_line_number	: 3002
}

Since the result is "unknown" we are highlighting it.  This seems to happen for lots of jobs.  If we can't parse steps, we just say the result is "unknown".  Perhaps we could do better checking in the log viewer controller that if the status of the ``job`` is success and the step us "unknown", then don't do this highlighting.

The code to decide this is here:
https://github.com/mozilla/treeherder/blob/master/ui/js/controllers/logviewer.js#L192-L192

Wes: Would you want to take a crack at this?  :)
Flags: needinfo?(cdawson) → needinfo?(wkocher)

Comment 4

7 months ago
Created attachment 8863099 [details] [review]
[treeherder] KWierso:b1360676 > mozilla:master
(Assignee)

Updated

7 months ago
Assignee: nobody → wkocher
Flags: needinfo?(wkocher)
(Assignee)

Comment 5

7 months ago
Comment on attachment 8863099 [details] [review]
[treeherder] KWierso:b1360676 > mozilla:master

I think this will do it. The log is no longer fully highlighted with this patch applied. Individual failure lines are still highlighted for the case of known steps. I haven't been able to find any failed jobs with unknown steps and no published failure lines to see what happens. If anyone can point me to one, I could test it.
Attachment #8863099 - Flags: review?(cdawson)
Comment on attachment 8863099 [details] [review]
[treeherder] KWierso:b1360676 > mozilla:master

I wasn't able to find one of the cases you mentioned.  So perhaps we'll have to cross that bridge when we come to it.

Asked in the PR, but would you open a bug for the other issue of hitting the console statement twice?  Possible we're doing wasted work there and it could be avoided.

Thanks.  :)
Attachment #8863099 - Flags: review?(cdawson) → review+

Comment 7

7 months ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/c15643cec07dfa579f590468952c72c0379fcdbf
Bug 1360676 - Only add line highlight to unknown steps if the job itself is marked as a failure (#2435) r=camd
(Assignee)

Updated

7 months ago
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.