Open Bug 1360693 Opened 9 years ago Updated 3 years ago

Reject passing getter_AddRefs to MOZ_DOES_NOT_ADDREF outparameters

Categories

(Developer Infrastructure :: Source Code Analysis, enhancement)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
enhancement

Tracking

(Not tracked)

People

(Reporter: nika, Unassigned)

References

(Depends on 1 open bug)

Details

This is a natural compliment to bug 1359455 in that we should not only ensure that people use getter_AddRefs when the outparameter does in fact addref, but we should also make sure that people don't use getter_AddRefs when it does not. From the previous patch many parameters are marked as MOZ_DOES_NOT_ADDREF, and these annotations can be used to ensure that getter_AddRefs is not used in places where it should not be.
Product: Core → Firefox Build System

Unassigning as I don't have time to work on this.

Assignee: nika → nobody
Product: Firefox Build System → Developer Infrastructure
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.