1360718 - Intermittent TEST-UNEXPECTED-PASS | /webvtt/rendering/cues-with-video/processing-model/disable_controls_reposition.html | expected FAIL

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Treeherder Bug Filer]

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=95300023&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/f_LNYOAtTZuE7oHHYhUO0w/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Intermittent Failures Robot]

10 failures in 883 pushes (0.011 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 3
* autoland: 3
* mozilla-central: 2
* try: 1
* graphics: 1

Platform breakdown:
* linux32: 7
* linux64: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1360718&startday=2017-04-24&endday=2017-04-30&tree=all

Comment 2

[Intermittent Failures Robot]

53 failures in 770 pushes (0.069 failures/push) were associated with this bug in the last 7 days. 

This is the #19 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* mozilla-inbound: 27
* try: 13
* autoland: 10
* graphics: 2
* oak: 1

Platform breakdown:
* linux32: 29
* linux64: 12
* windows8-64: 7
* windows7-32-vm: 3
* osx-10-10: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1360718&startday=2017-05-01&endday=2017-05-07&tree=all

Comment 3

[Benjamin Chen [:bechen]]

Per discuss with :ralin, 
we suspect that the "video.controls = false" is the key point.

1. The TextTrackManager::AddListeners listens the "resizevideocontrols seeked controlbarchange" is not enough. Perhaps we need to add some notification correspond to the "video.controls = false"

2. "video.controls = false performance is so slow.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

:bechen, will you own fixing this?

Comment 5

[Benjamin Chen [:bechen]]

Yeah, just find the root cause.

https://searchfox.org/mozilla-central/source/dom/media/webvtt/vtt.jsm#921
The |controlBarShown| doesn't handle the case that hide video control as the testcase

Comment 6

[Benjamin Chen [:bechen]]

Attachment: Bug 1360718 - Render the webvtt cues when hiding the control bar.

"video.controls = false" will remove the binding of videocontrols whci is a xul element.
In vtt.jsm, we need to remember the last show/hide status of videocontrols, then render cues when status changed.

Review commit: https://reviewboard.mozilla.org/r/137372/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137372/

Comment 7

[Alastor Wu [:alwu]]

Comment on attachment 8865758 [details]
Bug 1360718 - Render the webvtt cues when hiding the control bar.

https://reviewboard.mozilla.org/r/137372/#review140428

::: commit-message-38377:3
(Diff revision 1)
> +Bug 1360718 - Render the webvtt cues when hiding the control bar. r=alwu
> +
> +"video.controls = false" will remove the binding of videocontrols whci is a xul element.

s/whci/which

Comment 8

[Benjamin Chen [:bechen]]

Comment on attachment 8865758 [details]
Bug 1360718 - Render the webvtt cues when hiding the control bar.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137372/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c14e00984acc
Render the webvtt cues when hiding the control bar. r=alwu

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c14e00984acc

Comment 11

[Intermittent Failures Robot]

21 failures in 879 pushes (0.024 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 11
* autoland: 5
* try: 3
* mozilla-central: 2

Platform breakdown:
* linux32: 15
* linux64: 5
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1360718&startday=2017-05-08&endday=2017-05-14&tree=all