1360771 - Look for llvm-config39 as well as llvm-config-3.9

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jan Beich]

Downstream LLVM packages on FreeBSD currently don't provide unsuffixed llvm-config.

$ echo "ac_add_options --enable-stylo" >>.mozconfig
$ pkg install llvm39

$ ./mach bootstrap
$ ./mach build
[...]
 0:01.58 checking for llvm-config... not found
 0:01.59 ERROR: Could not find LLVM/Clang installation for compiling stylo build-time
 0:01.59 bindgen.  Please put 'llvm-config' in your PATH, specify the
 0:01.59 'LLVM_CONFIG' environment variable, or pass the '--with-libclang-path'
 0:01.59 and '--with-clang-path' options to configure.
 0:01.61 *** Fix above errors and then restart with\
 0:01.61                "/usr/local/bin/gmake -f client.mk build"

Comment 1

[Jan Beich]

Attachment: Bug 1360771 - llvm-config is N/A on FreeBSD try llvm-config39 as well.

Review commit: https://reviewboard.mozilla.org/r/134922/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134922/

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8863084 [details]
Bug 1360771 - llvm-config is N/A on FreeBSD try llvm-config39 as well.

https://reviewboard.mozilla.org/r/134922/#review137900

Thanks for maintaining bsd support! r=me with the commit message updated.

::: commit-message-6df3d:2
(Diff revision 1)
> +Bug 1360771 - Check for llvm-config39 in configure. r?rillian
> +

Please include a 'why' section of your commit message describing the motivation for the change. Something like
```
Bug 1360771 - Check for llvm-config39 in configure. r?rillian

FreeBSD does not provide an unversioned llvm-config and uses a different scheme for its versioned script names.
```

This information is clearly available in the referenced bug of course, but it's nice to have it available in the log as well.

Comment 3

[Jan Beich]

Comment on attachment 8863084 [details]
Bug 1360771 - llvm-config is N/A on FreeBSD try llvm-config39 as well.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/134922/diff/1-2/

Comment 4

[Jan Beich]

Comment on attachment 8863084 [details]
Bug 1360771 - llvm-config is N/A on FreeBSD try llvm-config39 as well.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/134922/diff/2-3/

Comment 5

[Ralph Giles (:rillian)]

Comment on attachment 8863084 [details]
Bug 1360771 - llvm-config is N/A on FreeBSD try llvm-config39 as well.

https://reviewboard.mozilla.org/r/134922/#review137904

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff984d234dd0
llvm-config is N/A on FreeBSD try llvm-config39 as well. r=rillian

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ff984d234dd0