Closed Bug 1360796 Opened 7 years ago Closed 7 years ago

Intermittent browser/components/extensions/test/browser/browser_ext_tabs_executeScript_bad.js | Promise rejected, expecting rejection to match /Missing host permission/, got "Message manager disconnected": Should not execute in `data:` frame -

Categories

(WebExtensions :: Untriaged, defect)

Product:
WebExtensions
Component:
Untriaged
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mixedpuppy)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed])

Attachments

(1 file)

Bug 1360796 fix intermittent assert,
59 bytes, text/x-review-board-request
mattw
: review+
Details 
this really picked up in the last week:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1360796&startday=2017-04-24&endday=2017-05-05&tree=all

a lot of debug, heavy on the osx side, all since April 29th!

I did some retriggers here to see if the pattern is obvious, maybe this will help:
https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=osx%20debug%20e10s-browser-chrome-1&tochange=05ea64eb8d85556e8f12af0335382cfa72fafce9&fromchange=796fdd50c2eb345382ec7ae3479dfdfece8cdf80&selectedJob=95388967



:andym, can you look at this or help find someone to look at this.  This is becoming higher in priority as it is more frequent.
Flags: needinfo?(amckay)
Whiteboard: [stockwell needswork]
the retriggers are done, I suspect this backout of bug 1354682 is the root cause:
https://hg.mozilla.org/integration/autoland/rev/fe58bf6ff79543d2ea940e631d55d8bc13c64d3b

that is extensions related, maybe that will give a clue?
Andy, this continues to fail at a very frequent failure rate, can you take a look at this real soon, or do you have a problem with us disabling this test until there is more time to look at it?
Assignee: nobody → mixedpuppy
Flags: needinfo?(amckay)
I think this is caused by an extra message being sent to the listener, it should be handled by being explicit about what messages the test listener handles.  Try is running, we'll see.
Comment on attachment 8867834 [details]
Bug 1360796 fix intermittent assert,

https://reviewboard.mozilla.org/r/139356/#review142690

Checking for the correct messages seems like a good idea to me.

::: browser/components/extensions/test/browser/browser_ext_tabs_executeScript_bad.js:155
(Diff revision 1)
>          <script src="page.js"></script>
>          <iframe id="inherited" src="data:text/html;charset=utf-8,inherited"></iframe>
>        `,
>        "page.js": function() {
>          browser.test.onMessage.addListener((msg, url) => {
> +          if (msg === "navigate") {

Nit: for consistency, could you make this the same as you do below where you return early if the wrong message is received, or vice versa?
Attachment #8867834 - Flags: review?(mwein) → review+
Comment on attachment 8867834 [details]
Bug 1360796 fix intermittent assert,

https://reviewboard.mozilla.org/r/139356/#review142720

::: browser/components/extensions/test/browser/browser_ext_tabs_executeScript_bad.js:155
(Diff revision 1)
>          <script src="page.js"></script>
>          <iframe id="inherited" src="data:text/html;charset=utf-8,inherited"></iframe>
>        `,
>        "page.js": function() {
>          browser.test.onMessage.addListener((msg, url) => {
> +          if (msg === "navigate") {

The two extensions are each sent only one type of message, the message names were more for documenting the intention.

::: browser/components/extensions/test/browser/browser_ext_tabs_executeScript_bad.js:182
(Diff revision 1)
>  
>        browser.test.onMessage.addListener(async msg => {
> +        if (msg !== "execute") {
> +          return;
> +        }
>          browser.test.assertRejects(

This is missing `await`, and could be the issue here.
> >        browser.test.onMessage.addListener(async msg => {
> > +        if (msg !== "execute") {
> > +          return;
> > +        }
> >          browser.test.assertRejects(
> 
> This is missing `await`, and could be the issue here.

good catch, that is the core issue.
https://hg.mozilla.org/mozilla-central/rev/7f3d55afb48e
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Whiteboard: [stockwell needswork] → [stockwell fixed]
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: