1360799 - Expose the requestIdleCallback API to chrome code unconditionally

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[(no longer active)]

We need to use this API in the front-end code, and in the off-chance
that we end up turning it off for the Web for whatever reason, or if
someone has turned off the pref, we should make sure our UI code does
not break.

Comment 1

[(no longer active)]

Attachment: Expose the requestIdleCallback API to chrome code unconditionally

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8863107 [details] [diff] [review]
Expose the requestIdleCallback API to chrome code unconditionally

I don't think IsPrivilegedChromeWindow is the right check, because it's false for a bunch of our UI.  For example, I'm pretty sure it's false for all our in-tab UI like about:preferences, about:addons, etc.

Probably better to just check nsContentUtils::IsSystemCaller(aCx).  Yes, this will also allow chrome to requestIdleCallback on a content window via Xrays, but I think that's fine.

r=me with that change made.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7af61811f270
Expose the requestIdleCallback API to chrome code unconditionally; r=bzbarsky

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7884a0eaf969
follow-up: Fix the comment in the header after addressing the review comment

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7af61811f270
https://hg.mozilla.org/mozilla-central/rev/7884a0eaf969