Closed Bug 1360810 Opened 3 years ago Closed 3 years ago
Add telemetry for privacy levels chosen by users
I'd like to see if I can make a case for removing the privacy level preferences as I suspect they're not making much sense anymore and the filtering degrades performance. But before I can do that I'd like to know how many people actually go into about:config and flip those prefs.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Comment on attachment 8863115 [details] [diff] [review] 0001-Bug-1360810-Add-telemetry-for-privacy-levels-chosen-.patch Review of attachment 8863115 [details] [diff] [review]: ----------------------------------------------------------------- LGTM! ::: browser/components/sessionstore/SessionStore.jsm @@ +616,5 @@ > this._initPrefs(); > this._initialized = true; > + > + let hist = Telemetry.getHistogramById("FX_SESSION_RESTORE_PRIVACY_LEVEL"); > + hist.add(Services.prefs.getIntPref("browser.sessionstore.privacy_level")); nit: You might as well chain these together and not use a temp var.
Attachment #8863115 - Flags: review?(mdeboer) → review+
Comment on attachment 8863115 [details] [diff] [review] 0001-Bug-1360810-Add-telemetry-for-privacy-levels-chosen-.patch Do you need this from the opt-out/release population to make a good decision? data-r=me either way FYI, you could also add this pref to TelemetryEnvironment.jsm:DEFAULT_ENVIRONMENT_PREFS
Attachment #8863115 - Flags: feedback?(benjamin) → feedback+
(In reply to Benjamin Smedberg [:bsmedberg] from comment #3) > Do you need this from the opt-out/release population to make a good > decision? data-r=me either way I'm guessing that the percentage of users flipping this pref (manually) is higher in the pre-release channels. We don't expose it via the UI and it's somewhat technical. > FYI, you could also add this pref to > TelemetryEnvironment.jsm:DEFAULT_ENVIRONMENT_PREFS I think I'd prefer keeping the session restore telemetry together for now. And this probe will go away soon-ish anyway... But thanks for the pointer! Didn't know that existed.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1de59d1f6fde Add telemetry for session restore privacy levels chosen by users r=mikedeboer data-r=bsmedberg
You need to log in before you can comment on or make changes to this bug.