1360810 - Add telemetry for privacy levels chosen by users

Status: RESOLVED FIXED

(Firefox :: Session Restore, enhancement)

Description

[Tim Taubert [:ttaubert] (inactive)]

I'd like to see if I can make a case for removing the privacy level preferences as I suspect they're not making much sense anymore and the filtering degrades performance. But before I can do that I'd like to know how many people actually go into about:config and flip those prefs.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1360810-Add-telemetry-for-privacy-levels-chosen-.patch

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8863115 [details] [diff] [review]
0001-Bug-1360810-Add-telemetry-for-privacy-levels-chosen-.patch

Review of attachment 8863115 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

::: browser/components/sessionstore/SessionStore.jsm
@@ +616,5 @@
>      this._initPrefs();
>      this._initialized = true;
> +
> +    let hist = Telemetry.getHistogramById("FX_SESSION_RESTORE_PRIVACY_LEVEL");
> +    hist.add(Services.prefs.getIntPref("browser.sessionstore.privacy_level"));

nit: You might as well chain these together and not use a temp var.

Comment 3

[Benjamin Smedberg]

Comment on attachment 8863115 [details] [diff] [review]
0001-Bug-1360810-Add-telemetry-for-privacy-levels-chosen-.patch

Do you need this from the opt-out/release population to make a good decision? data-r=me either way

FYI, you could also add this pref to TelemetryEnvironment.jsm:DEFAULT_ENVIRONMENT_PREFS

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Benjamin Smedberg [:bsmedberg] from comment #3)
> Do you need this from the opt-out/release population to make a good
> decision? data-r=me either way

I'm guessing that the percentage of users flipping this pref (manually) is higher in the pre-release channels. We don't expose it via the UI and it's somewhat technical.

> FYI, you could also add this pref to
> TelemetryEnvironment.jsm:DEFAULT_ENVIRONMENT_PREFS

I think I'd prefer keeping the session restore telemetry together for now. And this probe will go away soon-ish anyway... But thanks for the pointer! Didn't know that existed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1de59d1f6fde
Add telemetry for session restore privacy levels chosen by users r=mikedeboer data-r=bsmedberg

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1de59d1f6fde