Closed Bug 1360867 Opened 7 years ago Closed 7 years ago

Make a few classes final to possibly devirtualize some calls

Categories

(Core :: Layout, enhancement, P4)

Product:
Core
Component:
Layout
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)

Details

Attachments

(1 file)

fix
18.09 KB, patch
dholbert
: review+
Details | Diff | Splinter Review 
      No description provided.
Comment on attachment 8863165 [details] [diff] [review]
fix

Review of attachment 8863165 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, one optional nit:

::: layout/xul/nsTitleBarFrame.h
@@ +8,5 @@
>  #include "mozilla/Attributes.h"
>  #include "mozilla/EventForwards.h"
>  #include "nsBoxFrame.h"
>  
> +class nsTitleBarFrame : public nsBoxFrame

On this line, you're just removing some end-of-line whitespace, but *not* making the class final -- because it looks like this class does have subclasses, so indeed it can't be final.

So: maybe slightly better to split this tweak into its own whitespace-only patch, so that this patch is making the same change everywhere it touches (which is good for a large mechanical-ish patch like this one).
Attachment #8863165 - Flags: review?(dholbert) → review+
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37d1e983c5af
Make a few classes final to possibly devirtualize some calls.  r=dholbert
https://hg.mozilla.org/mozilla-central/rev/37d1e983c5af
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: