Closed
Bug 1360892
Opened 7 years ago
Closed 7 years ago
Make Telemetry for Graphite Opt-Out instead of Opt-In
Categories
(Core :: Graphics: Text, defect)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
mozilla55
People
(Reporter: tjr, Assigned: tjr)
References
Details
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
benjamin
:
review+
gchang
:
approval-mozilla-aurora-
gchang
:
approval-mozilla-beta+
|
Details |
In Bug 1331915 we added Telemetry for Graphite. However, because our Beta and Opt-In population is very skewed by locale, and we explicitly want to understand locale-specific usage, we want to make this item enabled by default.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8863185 -
Flags: review?(benjamin)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8863185 [details] Bug 1360892 Make Graphite Telemetry Opt-Out https://reviewboard.mozilla.org/r/134990/#review138052
Attachment #8863185 -
Flags: review?(benjamin) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/538011159bb1 Make Graphite Telemetry Opt-Out r=bsmedberg
Keywords: checkin-needed
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/538011159bb1
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8863185 [details] Bug 1360892 Make Graphite Telemetry Opt-Out Approval Request Comment [Feature/Bug causing the regression]: We would like to collect telemetry about a feature we have concerns about. [User impact if declined]: We will be delayed in making security decisions for our users. [Is this code covered by automated tests?]: Yes, we have tests that test graphite, so it will hit this call. [Has the fix been verified in Nightly?]: Yes. https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&end_date=2017-04-30&keys=__none__!__none__!__none__&max_channel_version=nightly%252F55&measure=SCALARS_BROWSER.USAGE.GRAPHITE&min_channel_version=null&processType=*&product=Firefox&sanitize=1&sort_keys=submissions&start_date=2017-04-28&table=0&trim=1&use_submission_date=0 [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: The parent to this bug, which is Bug 1331915 [Is the change risky?]: No [Why is the change risky/not risky?]: It adds a single Telemetry call. If it was going to crash, it should be crashing on Nightly. [String changes made/needed]: None
Attachment #8863185 -
Flags: approval-mozilla-beta?
Attachment #8863185 -
Flags: approval-mozilla-aurora?
Updated•7 years ago
|
status-firefox54:
--- → affected
Comment 6•7 years ago
|
||
Comment on attachment 8863185 [details] Bug 1360892 Make Graphite Telemetry Opt-Out Collect telemetry about Graphite Library to help us make the decision. Beta54+. Should be in 54 beta 5.
Attachment #8863185 -
Flags: approval-mozilla-beta?
Attachment #8863185 -
Flags: approval-mozilla-beta+
Attachment #8863185 -
Flags: approval-mozilla-aurora?
Attachment #8863185 -
Flags: approval-mozilla-aurora-
Comment 7•7 years ago
|
||
needs rebase for beta (maybe Bug 1331915 needs a uplift request too) grafting 414951:538011159bb1 "Bug 1360892 Make Graphite Telemetry Opt-Out r=bsmedberg" merging toolkit/components/telemetry/Scalars.yaml warning: conflicts while merging toolkit/components/telemetry/Scalars.yaml! (edit, then use 'hg resolve --mark') abort: unresolved conflicts, can't continue (use 'hg resolve' and 'hg graft --continue')
Flags: needinfo?(tom)
Assignee | ||
Comment 8•7 years ago
|
||
(In reply to Carsten Book [:Tomcat] from comment #7) > needs rebase for beta (maybe Bug 1331915 needs a uplift request too) Yea, I didn't realize that if B depends on A, I need to request A and B separately. I have done so now, sorry!
Flags: needinfo?(tom)
Comment 9•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/19b457181440
Comment 10•7 years ago
|
||
(In reply to Tom Ritter [:tjr] from comment #5) > [Is this code covered by automated tests?]: Yes, we have tests that test > graphite, so it will hit this call. > > [Has the fix been verified in Nightly?]: Yes. > https://telemetry.mozilla.org/new-pipeline/dist.html#! > cumulative=0&end_date=2017-04-30&keys=__none__!__none__! > __none__&max_channel_version=nightly%252F55&measure=SCALARS_BROWSER.USAGE. > GRAPHITE&min_channel_version=null&processType=*&product=Firefox&sanitize=1&so > rt_keys=submissions&start_date=2017-04- > 28&table=0&trim=1&use_submission_date=0 > > [Needs manual test from QE? If yes, steps to reproduce]: No Setting qe-verify- based on Tom's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: in-moztrap-
Updated•7 years ago
|
Flags: in-moztrap- → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•