1360980 - Remove unused `org.mozilla.gecko.browserid.verifier` package?

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Firefox Accounts, enhancement)

Description

[Ryan Kelly [:rfkelly]]

AFAICT the package `org.mozilla.gecko.browserid.verifier` has no consumers in the tree, e.g. this search shows only package declarations but no imports:

  https://dxr.mozilla.org/mozilla-central/search?q=browserid.verifier

We'd like to eventually retire the two servers "verifier.login.persona.org" and "verifier.accounts.firefox.com" that are referenced by files in that package, so if these are indeed not being used, can we please remove them from the tree so nobody gets tempted to start using them again?

Thanks :-)

Comment 1

[Owais Kazi]

Hello!
Should I remove the stated files having package `org.mozilla.gecko.browserid.verifier`?

Comment 2

[Ryan Kelly [:rfkelly]]

I'm going to redirect this to Grisha, who knows a lot more about the Android codebase than I do

Comment 3

[:Grisha Kruglov]

AFAIK this isn't used anywhere. Let's remove the dead code!

Owais, if you're keen, please submit a patch removing this package and corresponding mentions in the android-services.mozbuild file.

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.