1361111 - Crash in mozilla::ipc::MessageChannel::AssertWorkerThread | mozilla::ipc::MessageChannel::Send | mozilla::layers::PWebRenderBridgeChild::SendDeleteImage

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

This bug was filed from the Socorro interface and is 
report bp-fd000008-6f87-4437-b49e-82af60170501.
=============================================================

Got this pretty much on startup with webrender enabled on a clean profile. Looks like we're trying to do some IPC on a closed channel because the GPU process crashed previously and we're reinitializing.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1361111 - Avoid sending IPDL messages over a dead channel.

If the GPU process resets, we get a call to destroy the WebRenderLayerManager.
This in turns tries to send messages over the PWebRenderBridge channel which
has already been torn down. We should detect this case and avoid sending the
messages.

Review commit: https://reviewboard.mozilla.org/r/135258/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135258/

Comment 2

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8863467 [details]
Bug 1361111 - Avoid sending IPDL messages over a dead channel.

https://reviewboard.mozilla.org/r/135258/#review138272

How about another PWebRenderBridge messages?
I see a lot of PWebRenderBridge message sending without checking.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

In this case at least I only care about the GPU process reset case. There we explicitly call destroy on the WR LayerManager, and so code invoked from that destroy method should not assume the IPC channel is still working. It's true that the channel might get torn down during, say, a transaction, but I haven't seen that happen yet.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9530e0ce7d55
Avoid sending IPDL messages over a dead channel. r=jerry

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9530e0ce7d55