1361139 - remove test-related ssrc filtering from MediaPipeline now that RID filtering works

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P2)

Description

[Michael Froman [:mjf]]

The ssrc filtering code added for testing simulcast should be removed after verifying that RID filtering (Bug 1358224) has fixed the intermittents from Bug 1351531 and Bug 1351590).

MediaPipeline::SelectSsrc_m (and MediaPipeline::SelectSsrc_s)
https://dxr.mozilla.org/mozilla-central/rev/5278e2a35fc8f2be390243db1e62858bf0982055/media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp#773

PeerConnectionImpl::SelectSsrc
https://dxr.mozilla.org/mozilla-central/rev/5278e2a35fc8f2be390243db1e62858bf0982055/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp#2370

Also in related code in:
dom/media/PeerConnection.js
dom/webidl/PeerConnectionImpl.webidl
dom/webidl/RTCPeerConnection.webidl

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1361139 - pt 1 - remove mozSelectSsrc Chrome-only API for test-related ssrc filtering.

After changes from Bug 1358224 to add test-related RID filtering, we no longer
need the test-related SSRC filtering (which only partially worked).

Review commit: https://reviewboard.mozilla.org/r/137126/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137126/

Comment 2

[Michael Froman [:mjf]]

Attachment: Bug 1361139 - pt 2 - remove test-related SSRC filtering from MediaPipeline.

Now that RID filtering (Bug 1358224) has fixed the intermittant oranges
from Bug 1351531 and 1351590, remove the functionality from MediaPipeline.

Review commit: https://reviewboard.mozilla.org/r/137128/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137128/

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8865480 [details]
Bug 1361139 - pt 1 - remove mozSelectSsrc Chrome-only API for test-related ssrc filtering.

https://reviewboard.mozilla.org/r/137126/#review140236

Comment 4

[Nils Ohlmeier [:drno]]

Comment on attachment 8865481 [details]
Bug 1361139 - pt 2 - remove test-related SSRC filtering from MediaPipeline.

https://reviewboard.mozilla.org/r/137128/#review140280

Comment 5

[Michael Froman [:mjf]]

Based on the following evidence, we'll call this fix effective:

https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1351531&startday=2017-04-01&endday=2017-05-11&tree=all

https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1351590&startday=2017-04-01&endday=2017-05-11&tree=all

I'm going to rebase and ask for checkin.

Comment 6

[Michael Froman [:mjf]]

(In reply to Michael Froman [:mjf] from comment #5)
> Based on the following evidence, we'll call this fix effective:
By "this" I meant, the RID filtering fix in Bug 1358224.

Comment 7

[Michael Froman [:mjf]]

Comment on attachment 8865480 [details]
Bug 1361139 - pt 1 - remove mozSelectSsrc Chrome-only API for test-related ssrc filtering.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137126/diff/1-2/

Comment 8

[Michael Froman [:mjf]]

Comment on attachment 8865481 [details]
Bug 1361139 - pt 2 - remove test-related SSRC filtering from MediaPipeline.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137128/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27d6bc741a67
pt 1 - remove mozSelectSsrc Chrome-only API for test-related ssrc filtering. r=qdot
https://hg.mozilla.org/integration/autoland/rev/9876a25c48a9
pt 2 - remove test-related SSRC filtering from MediaPipeline. r=drno

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/27d6bc741a67
https://hg.mozilla.org/mozilla-central/rev/9876a25c48a9