Closed
Bug 1361157
Opened 8 years ago
Closed 8 years ago
Folder Pane Toolbar Label has been slightly moved to right
Categories
(Thunderbird :: Folder and Message Lists, defect)
Tracking
(thunderbird_esr5254+ fixed, thunderbird54 fixed, thunderbird55 fixed)
RESOLVED
FIXED
Thunderbird 55.0
People
(Reporter: ovari123, Assigned: Paenglab)
Details
Attachments
(3 files)
1.39 KB,
patch
|
aceman
:
review+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr52+
|
Details | Diff | Splinter Review |
2.02 KB,
image/png
|
Details | |
1.47 KB,
image/png
|
Details |
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170421105455
Steps to reproduce:
Menu Bar → View → Toolbars → Folder Pane Toolbar (enabled)
Actual results:
Image link below shows the “Folder Pane Toolbar” with “All Folders” selected; however, it is also been slightly moved to the right on Linux. On Windows it is shown correctly.
https://bugzilla.mozilla.org/show_bug.cgi?id=1360463#c14
https://bugzilla.mozilla.org/attachment.cgi?id=8863366
Updated•8 years ago
|
Component: Untriaged → Folder and Message Lists
Assignee | ||
Comment 2•8 years ago
|
||
No, unfortunately to bug 1354263. I'm on a patch.
Flags: needinfo?(richard.marti)
Assignee | ||
Comment 3•8 years ago
|
||
I move the rule to folderMenus.css because we have only icons in the menulist where we use them to show folders.
Or are other menulists with icon in it in our tree?
Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8863767 -
Flags: review?(acelists)
Assignee | ||
Comment 5•8 years ago
|
||
If the user sets the GTK icon size to 32px it would look like this without the rule.
Assignee | ||
Comment 7•8 years ago
|
||
With patch as it looks too without patch and normal 16px icons.
Comment on attachment 8863767 [details] [diff] [review]
Bug1361157.patch
Review of attachment 8863767 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks.
Attachment #8863767 -
Flags: review?(acelists) → review+
Assignee | ||
Updated•8 years ago
|
Comment 9•8 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8863767 [details] [diff] [review]
Bug1361157.patch
[Approval Request Comment]
Regression caused by (bug #): 1354263 which is in ESR52
User impact if declined: shifted text in menulists without icons
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Attachment #8863767 -
Flags: approval-comm-esr52?
Attachment #8863767 -
Flags: approval-comm-beta?
Updated•8 years ago
|
Attachment #8863767 -
Flags: approval-comm-beta? → approval-comm-beta+
Comment 11•8 years ago
|
||
Beta (TB 54):
https://hg.mozilla.org/releases/comm-beta/rev/a3dc003cd9e3c592f6537e5afb6f5613a1cfe12e
status-thunderbird54:
--- → fixed
status-thunderbird55:
--- → fixed
status-thunderbird_esr52:
--- → affected
Updated•8 years ago
|
Attachment #8863767 -
Flags: approval-comm-esr52? → approval-comm-esr52+
Comment 12•8 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•