Closed Bug 1361157 Opened 3 years ago Closed 3 years ago

Folder Pane Toolbar Label has been slightly moved to right

Categories

(Thunderbird :: Folder and Message Lists, defect)

Product:
Thunderbird
Component:
Folder and Message Lists
Version:
54 Branch
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr5254+ fixed, thunderbird54 fixed, thunderbird55 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 55.0
Tracking Flags:
Tracking Status
thunderbird_esr52 54+ fixed
thunderbird54 --- fixed
thunderbird55 --- fixed

People

(Reporter: ovari123, Assigned: Paenglab)

Details

Attachments

(3 files)

Bug1361157.patch
1.39 KB, patch
aceman
: review+
jorgk-bmo
: approval-comm-beta+
jorgk-bmo
: approval-comm-esr52+
Details | Diff | Splinter Review
32px-menulist.png
2.02 KB, image/png
Details
withPatch.png
1.47 KB, image/png
Details 
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170421105455

Steps to reproduce:

Menu Bar → View → Toolbars → Folder Pane Toolbar (enabled)


Actual results:

Image link below shows the “Folder Pane Toolbar” with “All Folders” selected; however, it is also been slightly moved to the right on Linux. On Windows it is shown correctly.

https://bugzilla.mozilla.org/show_bug.cgi?id=1360463#c14
https://bugzilla.mozilla.org/attachment.cgi?id=8863366
Component: Untriaged → Folder and Message Lists
Related to bug 1360463?
Flags: needinfo?(richard.marti)
No, unfortunately to bug 1354263. I'm on a patch.
Flags: needinfo?(richard.marti)
Attached patch Bug1361157.patch — — Splinter Review 
I move the rule to folderMenus.css because we have only icons in the menulist where we use them to show folders.

Or are other menulists with icon in it in our tree?
Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8863767 - Flags: review?(acelists)
Any screenshots what this is intended to do please?
Attached image 32px-menulist.png — 
If the user sets the GTK icon size to 32px it would look like this without the rule.
And with the patch? I can't set the icon sizes here.
Attached image withPatch.png — 
With patch as it looks too without patch and normal 16px icons.
Comment on attachment 8863767 [details] [diff] [review]
Bug1361157.patch

Review of attachment 8863767 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8863767 - Flags: review?(acelists) → review+
Keywords: checkin-needed
OS: Unspecified → Linux
Hardware: Unspecified → All
https://hg.mozilla.org/comm-central/rev/85e4fa4ed2d3c37f65cd820836d781b503dfd560
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
Comment on attachment 8863767 [details] [diff] [review]
Bug1361157.patch

[Approval Request Comment]
Regression caused by (bug #): 1354263 which is in ESR52
User impact if declined: shifted text in menulists without icons
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Attachment #8863767 - Flags: approval-comm-esr52?
Attachment #8863767 - Flags: approval-comm-beta?
Attachment #8863767 - Flags: approval-comm-beta? → approval-comm-beta+
Attachment #8863767 - Flags: approval-comm-esr52? → approval-comm-esr52+
You need to log in before you can comment on or make changes to this bug.