Closed Bug 1361183 Opened 3 years ago Closed 3 years ago

Should check Element::MayHaveAnimations() in EffectSet::GetEffectSet() first

Categories

(Core :: DOM: Animation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: hiro, Assigned: hiro)

Details

Attachments

(1 file)

Gecko_ElementHasAnimations() is appeared in bobby's profile [1] in bug 1360889 comment 5. And I realized we don't check ElementMayHaveAnimations() there. We should check it first.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=47255902848cfa2cfe19ce64bb3240238cd1b71e

[1] https://perfht.ml/2oYGJzC
Comment on attachment 8863510 [details]
Bug 1361183 - Check Element::MayHaveAnimations() in EffectSet::GetEffectSet().

https://reviewboard.mozilla.org/r/135280/#review138198
Attachment #8863510 - Flags: review?(bbirtles) → review+
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d75bc8568de
Check Element::MayHaveAnimations() in EffectSet::GetEffectSet(). r=birtles
https://hg.mozilla.org/mozilla-central/rev/8d75bc8568de
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.