Update Firefox Screenshots to version 6.6.0

RESOLVED FIXED in Firefox 54

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: _6a68, Assigned: _6a68)

Tracking

unspecified
Firefox 55
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox54 fixed, firefox55 fixed)

Details

Attachments

(1 attachment)

This bug updates the version of Firefox Screenshots in the tree from 5.5.0 to 6.6.0.

r? Standard8 to see if I've managed to push the patch to this bug correctly.

Changelog: https://github.com/mozilla-services/screenshots/blob/master/CHANGELOG.md#version-660
Whoops, comment 0 should say we're going from version 6.3.0 to 6.6.0.
Assignee: nobody → jhirsch

Comment 4

2 years ago
mozreview-review
Comment on attachment 8863536 [details]
Bug 1361208 - import latest version of Screenshots (6.6.0) into the tree;

https://reviewboard.mozilla.org/r/135306/#review138478

This looks fine. The only thing I'd say is it might be worth documenting in the screenshots repo the export process.

Since I'm fairly sure you haven't got level 3 access, I'll push this to autoland for you now.
Attachment #8863536 - Flags: review?(standard8) → review+

Comment 5

2 years ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/525326d5ddb1
import latest version of Screenshots (6.6.0) into the tree; r=standard8
Comment on attachment 8863536 [details]
Bug 1361208 - import latest version of Screenshots (6.6.0) into the tree;

Approval Request Comment
[Feature/Bug causing the regression]:
Bug 1356243. This will block us from enabling on Beta if it is not uplifted.

[User impact if declined]:
We will not be able to test Screenshots in Beta.

[Is this code covered by automated tests?]:
Yes.

[Has the fix been verified in Nightly?]:
Not yet.


[Needs manual test from QE? If yes, steps to reproduce]: 
No.

[List of other uplifts needed for the feature/fix]:
This is it.

[Is the change risky?][Why is the change risky/not risky?]::
Moderately. In addition to the test fix, it includes some small style fixes.

[String changes made/needed]:
None
Attachment #8863536 - Flags: approval-mozilla-beta?

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/525326d5ddb1
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
status-firefox54: --- → affected
Comment on attachment 8863536 [details]
Bug 1361208 - import latest version of Screenshots (6.6.0) into the tree;

In order to test Screenshots in Beta54. Beta54+. Should be in 54 beta 5.
Attachment #8863536 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
needs rebasing for beta like grafting 415112:525326d5ddb1 "Bug 1361208 - import latest version of Screenshots (6.6.0) into the tree; r=standard8"
merging browser/extensions/screenshots/bootstrap.js
warning: conflicts while merging browser/extensions/screenshots/bootstrap.js! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')
Flags: needinfo?(jhirsch)
Flags: needinfo?(jhirsch)

Comment 10

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/94d16b8d4a52
status-firefox54: affected → fixed
(In reply to Cory Price [:ckprice] from comment #6)
> [Is this code covered by automated tests?]:
> Yes.
> 
> [Has the fix been verified in Nightly?]:
> Not yet.
> 
> [Needs manual test from QE? If yes, steps to reproduce]: 
> No.

Setting qe-verify- based on Cory's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.