1361263 - Allow InvokeAsync() to accept a member function which is pass-by-reference

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

http://searchfox.org/mozilla-central/rev/ae8c2e2354db652950fe0ec16983360c21857f2a/xpcom/threads/MozPromise.h#1331

The implicit version of InvokeAsync() should be able to accept a member function which is pass-by-reference since StoreCopyPassByRRef<> ensure a copy is stored to free the worries of bug 1300476.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Decoder=1198b9800 MediaDecoderStateMachine State: GetMediaTime=0 GetClock=-1 mMediaSink=10e87a030 state=DECODING_FIRSTFRAME mPlayState=1 mSentFirstFrameLoadedEvent=0 IsPlaying=0 mAudioStatus=waiting mVideoStatus=idle mDecodedAudioEndTime=0 mDecodedVideoEndTime=33366mAudioCompleted=0 mVideoCompleted=0

mAudioStatus=waiting means the WAIT_FOR_DATA promise is not resolved.

I believe this is also the same issue as other EME test timeouts.

Comment 2

[Jean-Yves Avenard [:jya]]

I'm not sure I follow the link between a promise not being resolved and InvokeAsync to accept a member function passed by reference (and that last one I believe was done by :gerald in bug 1313497

For EME to not resolve WAIT_FOR_DATA typically means the decryption key wasn't received.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Sorry. I posted the comment to the wrong bug.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1361263 - allow InvokeAsync() to accept a member function which is pass-by-reference.

StoreCopyPassByRRef<> ensures a copy is stored in the runnable.
We don't have to worry about the concern of bug 1300476.

Review commit: https://reviewboard.mozilla.org/r/135538/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135538/

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8863760 [details]
Bug 1361263 - allow InvokeAsync() to accept a member function which is pass-by-reference.

https://reviewboard.mozilla.org/r/135538/#review138720

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdc6c6d80653
allow InvokeAsync() to accept a member function which is pass-by-reference. r=gerald

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bdc6c6d80653