Closed Bug 1361263 Opened 3 years ago Closed 3 years ago

Allow InvokeAsync() to accept a member function which is pass-by-reference

Categories

(Core :: XPCOM, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

http://searchfox.org/mozilla-central/rev/ae8c2e2354db652950fe0ec16983360c21857f2a/xpcom/threads/MozPromise.h#1331

The implicit version of InvokeAsync() should be able to accept a member function which is pass-by-reference since StoreCopyPassByRRef<> ensure a copy is stored to free the worries of bug 1300476.
Component: Audio/Video: Playback → XPCOM
Priority: -- → P3
See Also: → 1300476
Decoder=1198b9800 MediaDecoderStateMachine State: GetMediaTime=0 GetClock=-1 mMediaSink=10e87a030 state=DECODING_FIRSTFRAME mPlayState=1 mSentFirstFrameLoadedEvent=0 IsPlaying=0 mAudioStatus=waiting mVideoStatus=idle mDecodedAudioEndTime=0 mDecodedVideoEndTime=33366mAudioCompleted=0 mVideoCompleted=0

mAudioStatus=waiting means the WAIT_FOR_DATA promise is not resolved.

I believe this is also the same issue as other EME test timeouts.
Flags: needinfo?(jyavenard)
I'm not sure I follow the link between a promise not being resolved and InvokeAsync to accept a member function passed by reference (and that last one I believe was done by :gerald in bug 1313497

For EME to not resolve WAIT_FOR_DATA typically means the decryption key wasn't received.
Flags: needinfo?(jyavenard)
Sorry. I posted the comment to the wrong bug.
Attachment #8863760 - Flags: review?(gsquelart)
Comment on attachment 8863760 [details]
Bug 1361263 - allow InvokeAsync() to accept a member function which is pass-by-reference.

https://reviewboard.mozilla.org/r/135538/#review138720
Attachment #8863760 - Flags: review?(gsquelart) → review+
Thanks!
Assignee: nobody → jwwang
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bdc6c6d80653
allow InvokeAsync() to accept a member function which is pass-by-reference. r=gerald
https://hg.mozilla.org/mozilla-central/rev/bdc6c6d80653
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.