Closed Bug 1361267 Opened 5 years ago Closed 5 years ago

Followup to fix wrong if statement in ClearGetFilesHelpers()

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: jessica, Assigned: jessica)

References

Details

Attachments

(1 file, 1 obsolete file)

patch.
897 bytes, patch
jessica
: review+
Details | Diff | Splinter Review 
http://searchfox.org/mozilla-central/rev/38fdbbcaa4be3a3f5b0d207dc5d53fb687c42d6a/dom/html/HTMLInputElement.cpp#444-447

The if statement is testing mGetFilesNonRecursiveHelper, but it's unlinking mGetFilesRecursiveHelper.
Attached patch patch. (obsolete) — — Splinter Review 
Comment on attachment 8863611 [details] [diff] [review]
patch.

Sorry for the careless mistake. :(
Attachment #8863611 - Flags: review?(amarchesini)
Comment on attachment 8863611 [details] [diff] [review]
patch.

Since I noticed this, r+ :)
Attachment #8863611 - Flags: review?(amarchesini) → review+
Attached patch patch. — — Splinter Review 
Thanks Olli. :)

Updated reviewer's name.
Attachment #8863611 - Attachment is obsolete: true
Attachment #8863629 - Flags: review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/82f7bbcf6129
Followup to fix wrong if statement in ClearGetFilesHelpers(). r=smaug
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/82f7bbcf6129
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.