1361285 - Add new addresses and credit-card engines to about:preferences#sync

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P1)

Description

[Mark Hammond [:markh] [:mhammond]]

We agreed to split "History" into "Forms" and "History" (bug 1360746), but I believe we also expressed a desire to add more information to these checkboxes to indicate what to sync. We also need the exact wording for "Forms" (maybe just "Forms" :), and also where this checkbox should be placed (it's unfortunate that we will now have an odd number of engines)

IOW, we need a mockup of what about:preferences#sync should look like with this split in place - but *before* we add form autofill to the mix (ie, any descriptions should *not* include form autofill at this time, as the current plan is to land this change before form autofill is enabled).

Alex and Ryan, are you able to help with this?

Comment 1

[Lina Butler [:lina]]

From triage: Alex and Ryan wrote a draft of this in MTV, covering the benefit of enabling a sync engine. We want this for the next train.

Comment 2

[Ryan Feeley [:rfeeley]]

Just met with address autofill pm joe cheng (and also copywriter michelle and juwei). With respect to sync, we’ve decided it’s best to leave form history where it is (in history) and just add a new datatype called “Addresses”.

I'm working on descriptions, but to be honest, 8 datatypes plus 8 descriptions is too much information to show at once. I could add a twisty, but not in conjunction with a checkbox.

I don't see descriptions as related to adding Addresses.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Morphing this to reflect the new engine names based on comment 2

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1361285 - add new addresses and credit-cards engines to about:preferences.

Review commit: https://reviewboard.mozilla.org/r/141480/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141480/

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Attachment: new-engines.png

Ryan/Juwei, is this what you expect about:preferences to look like with these new engines?

Comment 6

[Juwei Huang[:juwei]]

Comment on attachment 8869918 [details]
new-engines.png

Looks good to me!

Comment 7

[Ryan Feeley [:rfeeley]]

Comment on attachment 8869918 [details]
new-engines.png

Good!

Comment 8

[Mark Hammond [:markh] [:mhammond]]

Turning this into the implementation bug.

Comment 9

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8869917 [details]
Bug 1361285 - add new addresses and credit-cards engines to about:preferences.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141480/diff/1-2/

Comment 10

[Edouard Oger [:eoger]]

Comment on attachment 8869917 [details]
Bug 1361285 - add new addresses and credit-cards engines to about:preferences.

https://reviewboard.mozilla.org/r/141480/#review155884

LGTM

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c68a93e32ad
add new addresses and credit-cards engines to about:preferences. r=eoger

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7c68a93e32ad