Closed Bug 1361285 Opened 2 years ago Closed 2 years ago

Add new addresses and credit-card engines to about:preferences#sync

Categories

(Firefox :: Sync, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: markh, Assigned: markh)

References

Details

Attachments

(2 files)

We agreed to split "History" into "Forms" and "History" (bug 1360746), but I believe we also expressed a desire to add more information to these checkboxes to indicate what to sync. We also need the exact wording for "Forms" (maybe just "Forms" :), and also where this checkbox should be placed (it's unfortunate that we will now have an odd number of engines)

IOW, we need a mockup of what about:preferences#sync should look like with this split in place - but *before* we add form autofill to the mix (ie, any descriptions should *not* include form autofill at this time, as the current plan is to land this change before form autofill is enabled).

Alex and Ryan, are you able to help with this?
From triage: Alex and Ryan wrote a draft of this in MTV, covering the benefit of enabling a sync engine. We want this for the next train.
Priority: -- → P1
Just met with address autofill pm joe cheng (and also copywriter michelle and juwei). With respect to sync, we’ve decided it’s best to leave form history where it is (in history) and just add a new datatype called “Addresses”.

I'm working on descriptions, but to be honest, 8 datatypes plus 8 descriptions is too much information to show at once. I could add a twisty, but not in conjunction with a checkbox.

I don't see descriptions as related to adding Addresses.
Morphing this to reflect the new engine names based on comment 2
Summary: UX for about:preferences#sync with forms and history split → UX for about:preferences#sync with new addresses and credit-card engines
Attached image new-engines.png
Ryan/Juwei, is this what you expect about:preferences to look like with these new engines?
Attachment #8869918 - Flags: ui-review?(rfeeley)
Attachment #8869918 - Flags: ui-review?(jhuang)
Comment on attachment 8869918 [details]
new-engines.png

Looks good to me!
Attachment #8869918 - Flags: ui-review?(jhuang) → ui-review+
Comment on attachment 8869918 [details]
new-engines.png

Good!
Attachment #8869918 - Flags: ui-review?(rfeeley) → ui-review+
Turning this into the implementation bug.
Assignee: rfeeley → markh
Summary: UX for about:preferences#sync with new addresses and credit-card engines → Add new addresses and credit-card engines to about:preferences#sync
Comment on attachment 8869917 [details]
Bug 1361285 - add new addresses and credit-cards engines to about:preferences.

https://reviewboard.mozilla.org/r/141480/#review155884

LGTM
Attachment #8869917 - Flags: review?(eoger) → review+
Pushed by mhammond@skippinet.com.au:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c68a93e32ad
add new addresses and credit-cards engines to about:preferences. r=eoger
https://hg.mozilla.org/mozilla-central/rev/7c68a93e32ad
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.