Closed Bug 1361311 Opened 7 years ago Closed 7 years ago

Remove project-editor from DevTools WebIDE

Categories

(DevTools Graveyard :: WebIDE, enhancement, P1)

Product:
DevTools Graveyard
Component:
WebIDE
Type:
enhancement

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: jdescottes, Assigned: jryans)

References

Details

(Whiteboard: [nosdk])

Attachments

(2 files)

Bug 1361311 - Remove project editor from WebIDE.
59 bytes, text/x-review-board-request
pbro
: review+
Details
Bug 1361311 - Remove project editor.
59 bytes, text/x-review-board-request
pbro
: review+
Details 
App development in WebIDE is being phased out. We should strip remove the project related features from WebIDE.

Note that we aim to replace WebIDE by aboutdebugging, but in the short term, removing the project part of WebIDE would allow us to close a few bugs (e.g. Bug 1353656)
:jryans, I checked telemetry for WEBIDE_PROJECT_EDITOR, and we still have a few hits on release. For reference, the inspector gets ~4 million hits, webide itself get 32k hits, and webide_project_editor gets 1k hits. Just wondering if I could be missing a use case.

From what you know is there still a valid use case for the project editor in webide today?
Blocks: 1181847
Flags: needinfo?(jryans)
Blocks: 1173950
Blocks: 1029741
Blocks: 1011030
Blocks: 1350645
(In reply to Julian Descottes [:jdescottes] from comment #1)
> :jryans, I checked telemetry for WEBIDE_PROJECT_EDITOR, and we still have a
> few hits on release. For reference, the inspector gets ~4 million hits,
> webide itself get 32k hits, and webide_project_editor gets 1k hits. Just
> wondering if I could be missing a use case.
> 
> From what you know is there still a valid use case for the project editor in
> webide today?

Well, I am sure someone will be upset, but I can't think of strong use case for it anymore.  WebIDE was always focused on making Firefox OS apps, and those have gone away now, so it seems fine to remove the project editor portion.

Basically, I think it's fine for WebIDE to become a thing that only does remote connection, anything else could reasonably be removed.

Is there any way to message to these users that it's going away?  You could add a notification bar for one cycle, or write about it in Discourse, perhaps?  Just an idea.
Flags: needinfo?(jryans)
I had a go at deleting some projecteditor-related code this morning. And the more I looked at the code and removed bits and pieces, the more I realized that I would have to delete pretty much everything :) 
I mean, not everything altogether (that would be bug 1314811), but a large portion of the code, and also a large part of the UI. 
This might be just because I don't know this code enough, but my impression so far is that this would require subtantial work in order to still have a UI that makes sense after the removal of everything projecteditor and app-related.

jryans, do you think there's a more "contained" way to remove projecteditor from webide? Something that would only involve essentially deleting code, maybe stubbing some stuff out, but leaving the UI mostly untouched? Maybe the concept of apps could stay.
If not, I don't know how valuable removing projecteditor is compared to just killing webide altogether (which, I know, has some implications related to salvaging remote connections, wifi/usb devices).
Flags: needinfo?(jryans)
(In reply to Patrick Brosset <:pbro> from comment #6)
> I had a go at deleting some projecteditor-related code this morning. And the
> more I looked at the code and removed bits and pieces, the more I realized
> that I would have to delete pretty much everything :) 
> I mean, not everything altogether (that would be bug 1314811), but a large
> portion of the code, and also a large part of the UI. 
> This might be just because I don't know this code enough, but my impression
> so far is that this would require subtantial work in order to still have a
> UI that makes sense after the removal of everything projecteditor and
> app-related.
> 
> jryans, do you think there's a more "contained" way to remove projecteditor
> from webide? Something that would only involve essentially deleting code,
> maybe stubbing some stuff out, but leaving the UI mostly untouched? Maybe
> the concept of apps could stay.
> If not, I don't know how valuable removing projecteditor is compared to just
> killing webide altogether (which, I know, has some implications related to
> salvaging remote connections, wifi/usb devices).

I think let's take the simpler path, at least to start with, of just removing the editor part only and leaving the projects concept in place.  This should make it possible to remove "projecteditor" without requiring a complex overhaul of WebIDE.

I'll give it a try.
Flags: needinfo?(jryans)
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment on attachment 8875443 [details]
Bug 1361311 - Remove project editor from WebIDE.

https://reviewboard.mozilla.org/r/146886/#review151166

Seems good to me. Thanks for helping Ryan!
Attachment #8875443 - Flags: review?(pbrosset) → review+
Comment on attachment 8875444 [details]
Bug 1361311 - Remove project editor.

https://reviewboard.mozilla.org/r/146888/#review151168

Yay! Less code to maintain!
Attachment #8875444 - Flags: review?(pbrosset) → review+
https://hg.mozilla.org/mozilla-central/rev/f7248d3f0d8a
https://hg.mozilla.org/mozilla-central/rev/3568cd107bf4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Flags: qe-verify-
Priority: P3 → P1
Whiteboard: [nosdk]
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: