Open Bug 1361347 Opened 3 years ago Updated 2 years ago

Can refreshIdentityBlock be optimized?

Categories

(Firefox :: Site Identity, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: florian, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fxperf:p3])

See https://perfht.ml/2pSTJLT for a profile of where we currently spend the time in it.
Priority: -- → P3
Here is a startup profile on a slow netbook, where we spend 34ms in refreshIdentityBlock: https://perfht.ml/2s1iTbR

I wonder if the code triggering this at http://searchfox.org/mozilla-central/rev/1a0d9545b9805f50a70de703a3c04fc0d22e3839/browser/base/content/browser.js#4383 is really needed? I wouldn't be surprised if we didn't have a page loaded yet at that point.
(In reply to Florian Quèze [:florian] [:flo] from comment #1)
> I wonder if the code triggering this at
> http://searchfox.org/mozilla-central/rev/
> 1a0d9545b9805f50a70de703a3c04fc0d22e3839/browser/base/content/browser.
> js#4383 is really needed? I wouldn't be surprised if we didn't have a page
> loaded yet at that point.

I think it's pretty much impossible to have page loaded there other than about:blank maybe.
(In reply to Dão Gottwald [::dao] from comment #2)
> (In reply to Florian Quèze [:florian] [:flo] from comment #1)
> > I wonder if the code triggering this at
> > http://searchfox.org/mozilla-central/rev/
> > 1a0d9545b9805f50a70de703a3c04fc0d22e3839/browser/base/content/browser.
> > js#4383 is really needed? I wouldn't be surprised if we didn't have a page
> > loaded yet at that point.
> 
> I think it's pretty much impossible to have page loaded there other than
> about:blank maybe.

Filed bug 1386594
Whiteboard: [fxperf]
Whiteboard: [fxperf] → [fxperf:p3]
You need to log in before you can comment on or make changes to this bug.