Closed Bug 1361401 Opened 7 years ago Closed 7 years ago

Chunk allocation count may be update by a helper thread

Categories

(Core :: JavaScript: GC, enhancement)

55 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

Attached patch stats-raceSplinter Review
TSAN complains about a race involving gc::Statistics::counts when this is updated by the background allocation task.

The simplest thing to do is make these counts atomic.
Attachment #8863771 - Flags: review?(sphink)
Attachment #8863771 - Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b70ba2c39199
Make gc::Statistics counts atomic as these can be updated by helper threads r=sfink
https://hg.mozilla.org/mozilla-central/rev/b70ba2c39199
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: