Closed
Bug 1361517
Opened 7 years ago
Closed 7 years ago
coverity report: Non-static class member "mAscent" is not initialized in this constructor nor in any functions that it calls.
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox53 | --- | wontfix |
firefox54 | --- | wontfix |
firefox55 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: emilio)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, regression, Whiteboard: [CID 1405756])
** CID 1405756: Uninitialized members (UNINIT_CTOR)
/layout/xul/nsBoxFrame.cpp: 141 in nsBoxFrame::nsBoxFrame(nsStyleContext *, mozilla::FrameType, bool, nsBoxLayout *)()
________________________________________________________________________________________________________
*** CID 1405756: Uninitialized members (UNINIT_CTOR)
/layout/xul/nsBoxFrame.cpp: 141 in nsBoxFrame::nsBoxFrame(nsStyleContext *, mozilla::FrameType, bool, nsBoxLayout *)()
135
136 if (layout == nullptr) {
137 NS_NewSprocketLayout(layout);
138 }
139
140 SetXULLayoutManager(layout);
>>> CID 1405756: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "mAscent" is not initialized in this constructor nor in any functions that it calls.
141 }
142
143 nsBoxFrame::~nsBoxFrame()
144 {
145 }
146
Reporter | ||
Comment 1•7 years ago
|
||
I don't see anyone initializing 'mFlex' either at first glance: http://searchfox.org/mozilla-central/rev/ae8c2e2354db652950fe0ec16983360c21857f2a/layout/xul/nsBoxFrame.h#209
Reporter | ||
Comment 2•7 years ago
|
||
Indeed. https://scan5.coverity.com/reports.htm#v47791/p10098/fileInstanceId=113895075&defectInstanceId=32009454&mergedDefectId=1405756 140 SetXULLayoutManager(layout); 4. uninit_member: Non-static class member mFlex is not initialized in this constructor nor in any functions that it calls. CID 1405756 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)6. uninit_member: Non-static class member mAscent is not initialized in this constructor nor in any functions that it calls. 141}
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c18005944b91 Initialize nsBoxFrame::{mFlex,mAscent}. r=mats
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c18005944b91
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•7 years ago
|
Assignee: nobody → emilio+bugs
status-firefox53:
--- → wontfix
status-firefox54:
--- → affected
status-firefox-esr52:
--- → unaffected
Updated•7 years ago
|
Blocks: coverity-analysis
Updated•7 years ago
|
Whiteboard: [CID 1405756]
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•