1361545 - Add a Gradle flavor for developing Photon for Firefox for Android

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

Description

[Nick Alexander :nalexander [he/him]]

In conversation with Max Liu, https://bugzilla.mozilla.org/show_bug.cgi?id=1355774, and https://bugzilla.mozilla.org/show_bug.cgi?id=1254353, there's been a desire to try building mobile Photon concepts using a Gradle flavor.  It's not hard to achieve and it might unblock work for a work-week starting May 8, 2017, so this ticket tracks landing such a split (without any build flags).

Sadly, this will require local developers to add a "skin" product flavor to their invocations, like:

./mach gradle app:assembleLocalAustralisDebug

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1361545 - Add "skin" flavorDimension for Photon mobile work.

This is pretty straight-forward.

Sadly, this will require local developers to add a "skin" product
flavor to their invocations, like:

./mach gradle app:assembleLocalAustralisDebug

In addition, this shows how many different variants of the Gradle
product flavor are embedded into our automation configurations.  I
can't solve that at this time.

Since I was here, I took the time to rename "automation" to
"official", which makes "localAustralis" the default in Android
Studio, avoiding a common issue with new builders producing an APK
that doesn't include omni.ja in the IDE.

Review commit: https://reviewboard.mozilla.org/r/135660/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135660/

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8863927 [details]
Bug 1361545 - Add "skin" flavorDimension for Photon mobile work.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135660/diff/1-2/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8863927 [details]
Bug 1361545 - Add "skin" flavorDimension for Photon mobile work.

https://reviewboard.mozilla.org/r/135660/#review138816

Nice! Thank you for your help :)

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8863927 [details]
Bug 1361545 - Add "skin" flavorDimension for Photon mobile work.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135660/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/289c6a3f7886
Add "skin" flavorDimension for Photon mobile work. r=sebastian

Comment 6

[Nick Alexander :nalexander [he/him]]

Message sent to mobile-firefox-dev: https://mail.mozilla.org/pipermail/mobile-firefox-dev/2017-May/002260.html.

Comment 7

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1361545 - Follow-up to fix Android Gradle builds.

Review commit: https://reviewboard.mozilla.org/r/135876/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135876/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34852f15ab22
Backed out changeset 289c6a3f7886 for busting Android gradle builds. r=backout
https://hg.mozilla.org/integration/autoland/rev/78b648c9c7d1
Add "skin" flavorDimension for Photon mobile work. r=sebastian,bustage-fix

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/78b648c9c7d1