Closed Bug 1361545 Opened 3 years ago Closed 3 years ago

Add a Gradle flavor for developing Photon for Firefox for Android

Categories

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

(Blocks 3 open bugs)

Details

Attachments

(2 files)

In conversation with Max Liu, https://bugzilla.mozilla.org/show_bug.cgi?id=1355774, and https://bugzilla.mozilla.org/show_bug.cgi?id=1254353, there's been a desire to try building mobile Photon concepts using a Gradle flavor.  It's not hard to achieve and it might unblock work for a work-week starting May 8, 2017, so this ticket tracks landing such a split (without any build flags).

Sadly, this will require local developers to add a "skin" product flavor to their invocations, like:

./mach gradle app:assembleLocalAustralisDebug
Assignee: nobody → nalexander
Comment on attachment 8863927 [details]
Bug 1361545 - Add "skin" flavorDimension for Photon mobile work.

https://reviewboard.mozilla.org/r/135660/#review138816

Nice! Thank you for your help :)
Attachment #8863927 - Flags: review?(s.kaspari) → review+
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/289c6a3f7886
Add "skin" flavorDimension for Photon mobile work. r=sebastian
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/34852f15ab22
Backed out changeset 289c6a3f7886 for busting Android gradle builds. r=backout
https://hg.mozilla.org/integration/autoland/rev/78b648c9c7d1
Add "skin" flavorDimension for Photon mobile work. r=sebastian,bustage-fix
https://hg.mozilla.org/mozilla-central/rev/78b648c9c7d1
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Blocks: 1379660
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 55 → mozilla55
You need to log in before you can comment on or make changes to this bug.