Missing cases in JS_GetTraceThingInfo()

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

a year ago
When producing a GC heap dump, I get a number of INVALID entries. Scope and RegExpShared seem to be missing. Null is also, though I hope no GC things have that TraceKind.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8863929 [details]
Bug 1361547, part 1 - Alphabetically sort existing cases in JS_GetTraceThingInfo().

https://reviewboard.mozilla.org/r/135664/#review138682
Attachment #8863929 - Flags: review?(sphink) → review+

Comment 4

a year ago
mozreview-review
Comment on attachment 8863930 [details]
Bug 1361547, part 2 - Implement missing cases in JS_GetTraceThingInfo().

https://reviewboard.mozilla.org/r/135666/#review138684

::: commit-message-33a7b:4
(Diff revision 1)
> +Bug 1361547, part 2 - Implement missing cases in JS_GetTraceThingInfo(). r=sfink
> +
> +MozReview-Commit-ID: GNteLjfArfg
> +

Oops. I saw your bug before I noticed you'd already attached a patch. I was worried that since there's nothing forcing these things to stay in sync, there's nothing preventing future mystery INVALIDs. So I set an isInvalid local in that case, and do:

         buf += n;
         bufsize -= n;
         *buf = '\0';
    
    +    if (isInvalid) {
    +        n = snprintf(buf, bufsize, "[%x]", unsigned(kind));
    +        buf += n;
    +        bufsize -= n;
    +    }
Attachment #8863930 - Flags: review?(sphink) → review+
(Assignee)

Comment 5

a year ago
I figured that the list is short enough that if you notice something is invalid you can just check which is missing. :)

Ideally we'd assert on INVALID, but I think that's only worthwhile if we're actually going to test this in automation.

Comment 6

a year ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/475b05d51af1
part 1 - Alphabetically sort existing cases in JS_GetTraceThingInfo(). r=sfink
https://hg.mozilla.org/integration/autoland/rev/8e05304275ae
part 2 - Implement missing cases in JS_GetTraceThingInfo(). r=sfink

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/475b05d51af1
https://hg.mozilla.org/mozilla-central/rev/8e05304275ae
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.