1361561 - Add GetCurrentVirtualThread and GetCurrentPhysicalThread

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

This change adds some functions that should be used instead of PR_GetCurrentThread. They both return a PRThread. GetCurrentPhysicalThread does exactly the same thing as PR_GetCurrentThread, but it makes it clearer what you're getting when there are cooperatively scheduled threads running.

GetCurrentVirtualThread returns the same value for all threads in a cooperative thread pool. The actual value it returns is somewhat immaterial. I kinda wonder if we should just make a new opaque type for it? Maybe a class with a single PRThread* field that would be passed around by value?

Anyway, the implementation of these two methods just calls PR_GetCurrentThread() for now. We can fix it up later to do whatever we need.

Comment 1

[Nathan Froyd [:froydnj]]

Comment on attachment 8863939 [details] [diff] [review]
patch

Review of attachment 8863939 [details] [diff] [review]:
-----------------------------------------------------------------

This works for me, thanks!  ++ for the comments as well.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d289923632be
Add GetCurrentVirtualThread function (r=froydnj)

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d289923632be