1361568 - TreeHerder's hover-text shows HTML encoding junk for quotes, ampersands, etc.

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Visit https://treeherder.mozilla.org/#/jobs?repo=try&revision=de3267cc37d18e37dbcaad4cc4e36de18725e8ef
  (Or any TreeHerder page with a quote or ampersand character in the commit message)

 2. Hover one of the commit messages with quotes or ampersands (e.g. the "part 3" one in my treeherder link above)

ACTUAL RESULTS:
The hover text includes HTML encoding junk like " ' and  & for double-quote, single-quote, and ampersand characters.

EXPECTED RESULTS:
Hover text should show the correct characters from the commit message.

(Note that I just used standard ASCII characters in my commit messages -- these aren't UTF fancy characters or anything.)

Comment 1

[Daniel Holbert [:dholbert]]

(I suspect this might be a regression in TreeHerder, because I did see that TreeHerder was updated last night (it notified me & asked me to reload), and I feel like I would've noticed this in the past if it had been like this for a while. Not 100% sure though.)

Comment 2

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:escapetitle > mozilla:master

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8863948 [details] [review]
[treeherder] KWierso:escapetitle > mozilla:master

This seems to work, but partially undoes what was done in bug 1067383 several years ago, so I don't know if we should do this. The non-tooltip versions of the messages are rendered with dangerouslySetInnerHTML and properly shows the strings as if they were unescaped.

I don't remember if this ever showed the unescaped strings in the tooltips. If it did, maybe the switch to rendering revisions via React messed it up?

Comment 4

[Ed Morley [:emorley]]

Comment on attachment 8863948 [details] [review]
[treeherder] KWierso:escapetitle > mozilla:master

I think Cameron might know what's best here :-)

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Alternatively, I could probably use react-bootstrap's tooltips to generate these, a la Bug 1340265...

Comment 6

[Cameron Dawson [:camd]]

Comment on attachment 8863948 [details] [review]
[treeherder] KWierso:escapetitle > mozilla:master

I added an alternative approach to the PR.  I hope you just love it.  ;)

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/33d2a877d81af6935e7030a60ca8d368472ac5a1
Bug 1361568 - Unescape commit messages used in the tooltips (#2444) r=camd

* Bug 1361568 - Unescape commit messages used in the tooltips