Apple Live Photos flicker to black

RESOLVED FIXED in Firefox 55

Status

()

Core
Canvas: 2D
P1
normal
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: jagger27.com, Assigned: kechen)

Tracking

({regression})

50 Branch
mozilla55
regression
Points:
---

Firefox Tracking Flags

(firefox-esr52 wontfix, firefox53 wontfix, firefox54 wontfix, firefox55 fixed)

Details

(Whiteboard: [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

7 months ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170413192749

Steps to reproduce:

On https://developer.apple.com/live-photos/ the Live Photos don't play properly.

macOS Sierra 10.12.4, MacBook Pro 13" (Late 2013)


Actual results:

The embedded videos flicker/fade to black


Expected results:

Video should play smoothly.
(Reporter)

Comment 1

7 months ago
Screen capture of issue: https://youtu.be/XedbKrPYPO8

Updated

7 months ago
Component: Untriaged → Graphics
Product: Firefox → Core

Comment 2

7 months ago
I can reproduce it on my MBP.
Status: UNCONFIRMED → NEW
Component: Graphics → Canvas: 2D
Ever confirmed: true
I was able to reproduce it. A simplified testcase would be helpful here.
Bisected it to bug 1289380.
Blocks: 1289380
Flags: needinfo?(nical.bugzilla)
I have not been able to reproduce this with the computers I have handy (none of which are macs), even with skia-gl canvas and gl layers enabled. Ethan, could you have a look?
Flags: needinfo?(nical.bugzilla) → needinfo?(ethlin)

Comment 6

7 months ago
(In reply to Nicolas Silva [:nical] from comment #5)
> I have not been able to reproduce this with the computers I have handy (none
> of which are macs), even with skia-gl canvas and gl layers enabled. Ethan,
> could you have a look?

Okay, I will look into this recently. I'll see how to create a simple testcase.

Updated

7 months ago
Flags: needinfo?(ethlin)
Keywords: regression
Priority: -- → P1
Whiteboard: [gfx-noted]

Comment 7

7 months ago
Keep the ni? to myself.
Flags: needinfo?(ethlin)
(Assignee)

Comment 8

7 months ago
testcase
This page uses a Javascript API called LivePhotosKit.
Looks like it creates several canvas elements in the same position and rotates the elements with z-index.

There is a simple test case that uses the API[1].

[1] https://people-mozilla.org/~kechen/LivePhotosKitTest.html

Comment 9

7 months ago
Kevin will look into this issue. Set him as the assignee.
Assignee: nobody → kechen
Flags: needinfo?(ethlin)
(Assignee)

Comment 10

7 months ago
Disable gfx.canvas.azure.accelerated can fix the bug.
Still trying to analysis the behavior of LivePhotosKit API.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 13

6 months ago
mozreview-review
Comment on attachment 8871226 [details]
Bug 1361574 - Restore texture after creating the video texture;

https://reviewboard.mozilla.org/r/142722/#review150014
Attachment #8871226 - Flags: review?(sotaro.ikeda.g) → review+
(Assignee)

Updated

6 months ago
Keywords: checkin-needed

Comment 14

6 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fc110df7b526
Restore texture after creating the video texture; r=sotaro
Keywords: checkin-needed

Comment 15

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fc110df7b526
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
This is too late for 54 at this point, but it is it severe enough that you think we should consider it for ESR52 backport still? Or can it just ride the 55 train?
status-firefox53: --- → wontfix
status-firefox54: --- → wontfix
status-firefox-esr52: --- → affected
Flags: needinfo?(kechen)
Version: 53 Branch → 50 Branch
(Assignee)

Comment 17

6 months ago
Looks like Apple already fixed this problem from their API side, the flicker problem from comment 0 doesn't exist in every firfox channel anymore.
Therefore, in my opinion, as long as there are not no other issues affected by this bug, it is okay to let it stay in 55.
Flags: needinfo?(kechen)
status-firefox-esr52: affected → wontfix
You need to log in before you can comment on or make changes to this bug.