1361641 - use srcdoc attr for iframes instead of data: in mochitests under dom/

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Convert the mochitests in dom to use srcdoc attributes, so once we turn off security.data_uri.inherit_security_context, those iframes will still have the same principal with parent document.

This bug will change lots of tests, I'd like to get opinion from smaug first, 
Smaug, do you think it's easier if I make it a giant patch with all the modicafications, or you like to review the fix one by one?

Thanks

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Also there are some tests that use <object data="data:text/html..."></object>, however <object> doesn't have srcdoc attributes, any suggestion to fix this?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

for <object> new files are probably needed.

I guess giant patch is ok for all the trivial changes, but if there is anything not to trivial, those could be put to separate patch?

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Olli Pettay [:smaug] from comment #2)
> for <object> new files are probably needed.
> 
> I guess giant patch is ok for all the trivial changes, but if there is
> anything not to trivial, those could be put to separate patch?
Okay, for the big patch I'll just change to srcdoc. 
Thanks

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: convert mochitest plain tests in dom to use srcdoc

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: convert mochitest plain tests in editor/ to use srcdoc.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: move data: URIs in <object> to seperate file.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi smaug
The patches are ready for review, when you have time can you help to review these ?

Thanks

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 4: move data: URIs in test_bug431701.html to seperate files.

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8864456 [details] [diff] [review]
Part 3: move data: URIs in <object> to seperate file.

Review of attachment 8864456 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/test/mochitest.ini
@@ +228,5 @@
>    intersectionobserver_cross_domain_iframe.html
>    intersectionobserver_window.html
> +  object_bug353334.html
> +  embed_bug455472.html
> +  object_bug455472.html

I am not sure the naming convention here, should it be "object_bug455472.html" or "bug455472_object.html"

Let me know if I am not doing it right.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8864453 [details] [diff] [review]
Part 1: convert mochitest plain tests in dom to use srcdoc

I think converting the test for bug 593174 is ok.
That was the only one requiring some thought.

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi Smaug
Thanks for your review, can you check my comment 10 to see if I did it right?

Thanks

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

not sure we have too strict naming convention.
Often non-test files are named
file_<testname>, but I think in this case using object_ or embed_ is ok

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/652e823f5301
Part 1: convert mochitest plain tests in dom to use srcdoc. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/73eba85671f7
Part 2: convert mochitest plain tests in editor/ to use srcdoc. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef29d70c9398
Part 3: move data: URIs in <object> to seperate file. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3b34b80fc13
Part 4: move data: URIs in test_bug431701.html to seperate files. r=smaug

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/652e823f5301
https://hg.mozilla.org/mozilla-central/rev/73eba85671f7
https://hg.mozilla.org/mozilla-central/rev/ef29d70c9398
https://hg.mozilla.org/mozilla-central/rev/b3b34b80fc13