1361657 - Crash: Unplug headphone after clicking refresh button and plug the headphone immediately.

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P1)

Description

[C.M.Chang[:chunmin]]

Step to reproduce:
1. Plug the headphone
2. Open a youtube video
3. Refresh the page
4. Upon refreshing the page, unplug the headphone
5. Plug the headphone again

It doesn't happen every time, so I guess it's a timing issue happens on a device change.

Comment 1

[Jean-Yves Avenard [:jya]]

Can you provide a crash report?

Comment 2

[Alex Chronopoulos [:achronop]]

Can you also provide platform?

Comment 3

[C.M.Chang[:chunmin]]

(In reply to Alex Chronopoulos [:achronop] from comment #2)
> Can you also provide platform?
Mac OS 10.12

Comment 4

[C.M.Chang[:chunmin]]

(In reply to Jean-Yves Avenard [:jya] from comment #1)
> Can you provide a crash report?
It doesn't show on my about:crashes, so I have no report to submit. It just shows "Gah. Your tab just crashed." on my page.

It's more likely happens on a long video like: https://www.youtube.com/watch?v=jJMnOVWMFOo

Comment 5

[Paul Adenot (:padenot)]

Alex, care to have a look?

Comment 6

[Alex Chronopoulos [:achronop]]

Sure, I will try to repro tomorrow.

Comment 7

[Blake Wu [:bwu][:blakewu]]

I hit a similar crash two days ago. But my crash report[1] looks weird and empty. I cannot see it is related to audio.  

[1]https://crash-stats.mozilla.com/report/index/b53d4d11-c577-49b1-99f5-5b3040170502

Comment 8

[Alex Chronopoulos [:achronop]]

I am not able to repro, it's sporadic though, I will try again after importing latest cubeb

Comment 9

[Alex Chronopoulos [:achronop]]

Can you please provide logs (cubeb:4) of the error. If it takes many retries to repro, it would be nice to include them in the logs (I hope to see there the difference in timing)

Comment 10

[C.M.Chang[:chunmin]]

Attachment: crash.log

(In reply to Alex Chronopoulos [:achronop] from comment #9)
> Can you please provide logs (cubeb:4) of the error. If it takes many retries
> to repro, it would be nice to include them in the logs (I hope to see there
> the difference in timing)
Sure. I got one on my ASAN build. The attached log is from my terminal with cubeb log enabled.

Comment 11

[Alex Chronopoulos [:achronop]]

ASAN logs are excellent piece of information! It's clear that the crash occurs because the unplug event fired in thread T87 right after the stream is destroyed due to a normal AudioStream::Shutdown() in thread T46. Inside the handler of unplug event we attempt to use the destroyed stream.

Comment 12

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This is an assigned P1 bug without activity in two weeks. 

If you intend to continue working on this bug for the current release/iteration/sprint, remove the 'stale-bug' keyword.

Otherwise we'll reset the priority of the bug back to '--' on Monday, August 28th.

Comment 13

[Alex Chronopoulos [:achronop]]

Fixed by 1366707