1361659 - Coverity report: mozilla::​BRFrame::​BRFrame(nsStyleContext *): A scalar field is not initialized by the constructor

Status: RESOLVED FIXED

(Core :: Layout, defect, P4)

Description

[Mats Palmgren (inactive)]

Coverity CID 1396665 Uninitialized scalar field

The field will contain an arbitrary value left over from earlier computations.

In mozilla::​BRFrame::​BRFrame(nsStyleContext *): A scalar field is not initialized by the constructor


 65protected:
 66  explicit BRFrame(nsStyleContext* aContext)
 67    : nsFrame(aContext, LayoutFrameType::Br)
   CID 1396665 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)2. uninit_member: Non-static class member mAscent is not initialized in this constructor nor in any functions that it calls.
 68  {}

Comment 1

[Mats Palmgren (inactive)]

This is sort of a false positive since we only use mAscent in GetLogicalBaseline()
and mAscent is always set in Reflow(), and Reflow() must be called before
GetLogicalBaseline().

We should probably init mAscent in the ctor to NS_INTRINSIC_WIDTH_UNKNOWN anyway
to catch any errors.  (Maybe also rename it to mBaseline to follow the naming
convention used in other classes.)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/952e377dbace
Initialize BRFrame::mAscent. r=mats

Comment 3

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/952e377dbace