1361676 - [DateTimePicker] Show selection highlight on date picker

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Scott Wu [:scottwu]]

Show highlight on selected date on date picker according to UX & visual spec (Bug 1069609)

Comment 1

[Scott Wu [:scottwu]]

Attachment: Bug 1361676 - Show selection highlight on date picker.

Review commit: https://reviewboard.mozilla.org/r/136062/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136062/

Comment 2

[Scott Wu [:scottwu]]

In this patch, the `selection` object is used to track what `year`, `month`, and `day` is selected. Highlight only appears when all 3 properties are present.

This patch is intended to land after Bug 1320647.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8864381 [details]
Bug 1361676 - Show selection highlight on date picker.

https://reviewboard.mozilla.org/r/136062/#review140376

Seems okay - but I didn't test it. Thanks for the patch!

Comment 4

[Scott Wu [:scottwu]]

Comment on attachment 8864381 [details]
Bug 1361676 - Show selection highlight on date picker.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136062/diff/1-2/

Comment 5

[Scott Wu [:scottwu]]

Thanks Mike!

Rebased to central and tweaked a few CSS rules.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1500391c1530
Show selection highlight on date picker. r=mconley

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1500391c1530