Closed Bug 1361676 Opened 4 years ago Closed 4 years ago

[DateTimePicker] Show selection highlight on date picker

Categories

(Core :: Layout: Form Controls, defect)

54 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: scottwu, Assigned: scottwu)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Show highlight on selected date on date picker according to UX & visual spec (Bug 1069609)
Attachment #8864381 - Flags: review?(mconley)
In this patch, the `selection` object is used to track what `year`, `month`, and `day` is selected. Highlight only appears when all 3 properties are present.

This patch is intended to land after Bug 1320647.
Depends on: 1320647
Comment on attachment 8864381 [details]
Bug 1361676 - Show selection highlight on date picker.

https://reviewboard.mozilla.org/r/136062/#review140376

Seems okay - but I didn't test it. Thanks for the patch!
Attachment #8864381 - Flags: review?(mconley) → review+
Thanks Mike!

Rebased to central and tweaked a few CSS rules.
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1500391c1530
Show selection highlight on date picker. r=mconley
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1500391c1530
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.